Skip to content

Update default hostconfigs for color contrast#4206

Merged
paulcam206 merged 2 commits into
mainfrom
paulcam/default-color-contrast
Jun 24, 2020
Merged

Update default hostconfigs for color contrast#4206
paulcam206 merged 2 commits into
mainfrom
paulcam/default-color-contrast

Conversation

@paulcam206

@paulcam206 paulcam206 commented Jun 22, 2020

Copy link
Copy Markdown
Member

Related Issue

Fixes VSO #23940361
Fixes VSO #24096212
Partially fixes VSO #24094745

Description

Some of our default colors fail to meet WCAG's color contrast guidelines. In particular:

  • the default green color used for "color": "good" (new green is only a bit darker)
  • the default red color used for "color": "attention" (new red is only a bit darker)
  • the default yellow color used for "color": "warning" (now we use a darker orange color -- yellow is a bad color to use on a white background when it comes to luminosity)
  • the default gray for "isSubtle": true (new gray is only a bit darker)
  • the default background gray for Container's "style": "emphasis" (new gray is a bit lighter to enhance foreground contrast)

TextBlock sample (before):
image

TextBlock sample (after):
image

ColumnSet sample (before):
image

ColumnSet sample (after):
image

isSubtle sample (before):
image

isSubtle sample (after):
image

How Verified

  • local build, devtools color testing
Microsoft Reviewers: Open in CodeFlow

@ghost

ghost commented Jun 22, 2020

Copy link
Copy Markdown

Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@paulcam206

Copy link
Copy Markdown
Member Author

updated description with screenshots to aid in the discussion :)

@paulcam206 paulcam206 merged commit 75eeb11 into main Jun 24, 2020
@paulcam206 paulcam206 deleted the paulcam/default-color-contrast branch June 24, 2020 15:15
@shalinijoshi19 shalinijoshi19 added AdaptiveCards v1.2.10 Platform-JavaScript Bugs or features related to the JavaScript renderer and removed AdaptiveCards v1.2.10 labels Jul 6, 2020
@ghost

ghost commented Jul 7, 2020

Copy link
Copy Markdown

@shalinijoshi19 shalinijoshi19 added this to the 20.06 milestone Jul 10, 2020
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Accessibility Bugs around feature accessibility Platform-JavaScript Bugs or features related to the JavaScript renderer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants