Skip to content

Ts/fixes#4268

Merged
shalinijoshi19 merged 5 commits into
mainfrom
ts/fixes
Jul 6, 2020
Merged

Ts/fixes#4268
shalinijoshi19 merged 5 commits into
mainfrom
ts/fixes

Conversation

@dclaux

@dclaux dclaux commented Jul 1, 2020

Copy link
Copy Markdown
Member

Related Issue

Fixes #4043
Fixes #4267
Fixes #4233

Description

Fixes regression that prevented cascading ShowCards to work properly in designer
Fixes regression that prevented TextBlock (and other elements) from being hidden when isVisible = false
Updates ImageSet handling to disallow the use of the auto and stretch sizes

How Verified

Verified manually in adaptivecards-designer-app

Microsoft Reviewers: Open in CodeFlow

@ghost

ghost commented Jul 1, 2020

Copy link
Copy Markdown

Hi @dclaux. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@shalinijoshi19 shalinijoshi19 added AdaptiveCards v20.06 Platform-JavaScript Bugs or features related to the JavaScript renderer labels Jul 6, 2020
@shalinijoshi19 shalinijoshi19 merged commit 5d19a01 into main Jul 6, 2020
@shalinijoshi19 shalinijoshi19 deleted the ts/fixes branch July 6, 2020 20:01
@shalinijoshi19 shalinijoshi19 added this to the 20.06 milestone Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform-JavaScript Bugs or features related to the JavaScript renderer

Projects

None yet

4 participants