[Designer] Remove border when background image is present and move logic to widget container class#8022
Merged
anna-dingler merged 1 commit intoanna/berlincontainerfrom Nov 9, 2022
Conversation
…et container class
|
Hi @anna-dingler. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
anna-dingler
requested review from
KesemZ,
jwoo-msft,
licanhua and
paulcam206
and removed request for
licanhua and
paulcam206
paulcam206
approved these changes
Nov 9, 2022
| this.appendErrorMessage(Strings.widgetOverflowWarning); | ||
| } | ||
| } | ||
| this._hostContainer.adjustStyleForWidgetBackground(); |
Member
There was a problem hiding this comment.
we should be calling an abstract method here so any host container can use this functionality
anna-dingler
added a commit
that referenced
this pull request
Nov 10, 2022
* Switch padding to margin and update card heights * Adjust width and height for border * Switch header to use margins * Update widget container styling * Remove border when background image is present and move logic to widget container class (#8022) * Remove host container logic from card designer surface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #7958
Description
Removes border from Widgets Container if a background image has been set.
Also moved widget container styling changes to the WidgetContainer class.
Sample Card
https://github.com/microsoft/AdaptiveCards/blob/2facb28c481b7a16968158b81d2669853d689497/samples/v1.0/Scenarios/WeatherLarge.json
How Verified
Verified manually on the AdaptiveCards designer.
Microsoft Reviewers: Open in CodeFlow