Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue with Microsoft Graph inheritable permissions failing during the setup process. The fix ensures that Graph permission failures are tracked separately as warnings rather than causing complete setup failures, allowing partial success scenarios.
Changes:
- Added tracking for Graph inheritable permissions failures through new properties in
SetupResultsandBlueprintCreationResult - Enhanced error handling to treat Graph permission failures as warnings with recovery actions
- Added comprehensive test coverage for the new Graph permission failure scenarios
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SetupResults.cs | Added GraphInheritablePermissionsFailed property to track Graph permission failures |
| SetupHelpers.cs | Added recovery action display for Graph permission failures |
| BlueprintSubcommand.cs | Updated blueprint creation to return Graph permission failure status and error details |
| AllSubcommand.cs | Added logic to track and warn about Graph permission failures |
| SetupResultsTests.cs | Added comprehensive tests for SetupResults and BlueprintCreationResult classes |
| SetupHelpersDisplaySummaryTests.cs | Added tests for display summary with Graph permission failure scenarios |
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/BlueprintSubcommand.cs
Show resolved
Hide resolved
tmlsousa
reviewed
Feb 2, 2026
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/SetupHelpers.cs
Show resolved
Hide resolved
Collaborator
|
In the status summary, we should explictly call out whose inheritable permissions are set |
tmlsousa
previously approved these changes
Feb 3, 2026
Contributor
Author
Fixed : |
rahuldevikar761
approved these changes
Feb 4, 2026
joratz
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show the graph consent/inheritable permissions failure in Setup summary
Fix Tested :
