Conversation
…sync to catch and log detailed errors that may cause the CLI to crash during blueprint creation. Add null checks and more robust parsing to prevent unhandled exceptions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses the “application terminated unexpectedly” crash reported during agent blueprint creation by strengthening error handling and adding more detailed logging around inheritable-permissions updates in AgentBlueprintService.
Changes:
- Wrap the inheritable-permissions PATCH call with exception handling to prevent unhandled exceptions from bubbling up.
- Add additional warning/error logs to provide more context (blueprint/resource) when PATCH fails.
- Improve the outer exception log to include the exception object (stack trace) and more context.
- Propagate OperationCanceledException in both inner (PATCH) and outer catch blocks so Ctrl+C is not swallowed as a generic error result - Hoist blueprintObjectId before the try block so the resolved object ID is available in the outer catch log (falls back to blueprintId if resolve failed) - Replace generic "PATCH failed" error string with a descriptive message that includes the blueprint and resource IDs - Add regression tests: SetInheritablePermissionsAsync_ReturnsFalse_WhenPatchThrows and SetInheritablePermissionsAsync_ReturnsFalse_WhenPatchReturnsFalse - Add CHANGELOG entries for the crash fix and cancellation propagation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sellakumaran
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #366
Summary: Fix crash during agent blueprint creation by improving error handling and logging in AgentBlueprintService
Changes
src/Microsoft.Agents.A365.DevTools.Cli/Services/AgentBlueprintService.cs: Improve error handling and logging in SetInheritablePermissionsAsync to catch and log detailed errors that may cause the CLI to crash during blueprint creation. Add null checks and more robust parsing to prevent unhandled exceptions.This PR was created automatically by AI Team Mate 🤖
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com