Skip to content

Removing package, approve and block develop-mcp commands#439

Merged
deepaligargms merged 2 commits into
mainfrom
u/deepaligarg/deprecatecmd
Jun 4, 2026
Merged

Removing package, approve and block develop-mcp commands#439
deepaligargms merged 2 commits into
mainfrom
u/deepaligarg/deprecatecmd

Conversation

@deepaligargms
Copy link
Copy Markdown
Contributor

@deepaligargms deepaligargms commented Jun 1, 2026

Removes three a365 develop-mcp subcommands whose responsibilities have moved out of the developer CLI and into the Microsoft Admin Center:

a365 develop-mcp approve
a365 develop-mcp block
a365 develop-mcp package-mcp-server

Server approval/blocking and package submission are administrative, tenant-governed operations — they belong with tenant admins in the Admin Center, not in a developer-facing CLI. This PR deletes the commands plus their now-dead supporting code:

Commands/DevelopMcpCommand.cs — the three subcommands (~228 lines)
Helpers/PackageMCPServerHelper.cs — package generation helper
Services/Agent365ToolingService.cs / IAgent365ToolingService.cs — GetServerInfoAsync, ApproveServerAsync, BlockServerAsync
Constants/McpConstants.cs — constants used only by the removed paths
Docs: docs/commands/README.md, Helpers/README.md, CHANGELOG.md

Why now
The approval, blocking, and Admin-Center-submission workflows are now performed directly in the Microsoft Admin Center(https://admin.microsoft.com/#/homepage), making the CLI equivalents redundant and a source of drift (two code paths for the same governance action).Anyone currently scripting these commands should move to the Admin Center:

Removed command Replacement
a365 develop-mcp approve Approve in Microsoft admin center → Requested Agents
a365 develop-mcp block Manage/block in Microsoft admin center → Agents
a365 develop-mcp package-mcp-server No CLI equivalent — admins onboard and manage servers directly in the Microsoft Admin Center; no local package artifact is produced

These are admin operations, so there is intentionally no CLI replacement — the actions require a tenant admin in the Admin Center.

Test Plan

  • DevelopMcpCommandTests.CreateCommand_*: command.Subcommands.Should().HaveCount(5) now passes (was 8), and the subcommand-name assertions no longer expect approve/block/package-mcp-server.
  • Removed the now-obsolete tests for the deleted commands: PackageMcpServerSubcommand_HasCorrectOptions, ApproveSubcommand_IsImplementedWithCorrectOptions, BlockSubcommand_IsImplementedWithCorrectOptions, and the corresponding [InlineData] rows for approve/block in the option-alias theory.
  • DevelopMcpCommandRegressionTests updated to match the reduced surface.
  • Full suite green: cd src && dotnet test tests.proj --configuration Release.
  • Manual smoke: a365 develop-mcp --help lists only the 5 remaining subcommands; a365 develop-mcp approve returns an unrecognized-command error.

@deepaligargms deepaligargms marked this pull request as ready for review June 1, 2026 21:48
@deepaligargms deepaligargms requested review from a team as code owners June 1, 2026 21:48
Copilot AI review requested due to automatic review settings June 1, 2026 21:48
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jun 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the develop-mcp approve, develop-mcp block, and develop-mcp package-mcp-server subcommands from the CLI, along with their supporting service methods, helper class, constants, and tests. These functions are now handled via the Microsoft Admin Center.

Changes:

  • Drop approve, block, and package-mcp-server subcommands and their handlers from DevelopMcpCommand.
  • Remove ApproveServerAsync, BlockServerAsync, GetServerInfoAsync from IAgent365ToolingService/Agent365ToolingService, plus URL builder helpers; delete PackageMCPServerHelper and its McpConstants.PackageMCPServer template.
  • Update tests (DevelopMcpCommandTests, DevelopMcpCommandRegressionTests), Helpers/README.md, docs/commands/README.md, and add a CHANGELOG.md entry under [Unreleased] > Removed.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopMcpCommand.cs Removes registration and definitions of the three subcommands.
src/Microsoft.Agents.A365.DevTools.Cli/Services/IAgent365ToolingService.cs Removes Approve/Block/GetServerInfo method declarations.
src/Microsoft.Agents.A365.DevTools.Cli/Services/Agent365ToolingService.cs Removes corresponding implementations and URL builders.
src/Microsoft.Agents.A365.DevTools.Cli/Helpers/PackageMCPServerHelper.cs Deletes the packaging helper.
src/Microsoft.Agents.A365.DevTools.Cli/Constants/McpConstants.cs Removes PackageMCPServer constants/template.
src/Microsoft.Agents.A365.DevTools.Cli/Helpers/README.md Drops the helper from the docs table.
docs/commands/README.md Removes the three command links.
src/Tests/.../DevelopMcpCommandTests.cs Adjusts subcommand count/list and removes per-subcommand tests.
src/Tests/.../DevelopMcpCommandRegressionTests.cs Removes approve/block dry-run and integration tests.
CHANGELOG.md Adds Removed entries documenting the deprecations.

Comment thread CHANGELOG.md
@sellakumaran
Copy link
Copy Markdown
Contributor

PR description is empty.

No test plan, no rationale for users of the removed commands, no link to the Admin Center workflow that replaces them.

Fill in:

  • Why now (what triggered the removal — Admin Center GA? deprecation period elapsed?)
  • Test plan: at minimum, command.Subcommands.Should().HaveCount(5) passes; full test suite green
  • Migration path for users currently scripting approve/block/package-mcp-server — where do they go in Admin Center

@sellakumaran
Copy link
Copy Markdown
Contributor

PR title: "Deprecating package, approve and block mcp commands". The diff deletes handlers, service methods, helper, constants, and tests — that's a removal, not a deprecation (which would keep the commands working and emit a warning).

Pick one:

  • Rename PR to Remove package-mcp-server, approve, and block develop-mcp commands
  • Or actually implement deprecation: keep the handlers, emit "This command is deprecated and will be removed in <version>. Use Microsoft Admin Center instead.", schedule the removal for a later PR

Comment thread docs/commands/README.md
@deepaligargms deepaligargms changed the title Deprecating package, approve and block mcp commands Removing package, approve and block develop-mcp commands Jun 2, 2026
@deepaligargms
Copy link
Copy Markdown
Contributor Author

DO NOT MERGE until #400 is merged

Copilot AI review requested due to automatic review settings June 4, 2026 16:53
@deepaligargms deepaligargms force-pushed the u/deepaligarg/deprecatecmd branch from fa61832 to 1ad4897 Compare June 4, 2026 16:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

@deepaligargms deepaligargms enabled auto-merge (squash) June 4, 2026 19:41
@deepaligargms deepaligargms merged commit 302e32e into main Jun 4, 2026
10 checks passed
@deepaligargms deepaligargms deleted the u/deepaligarg/deprecatecmd branch June 4, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants