Skip to content

Fix CS1998 async warning in PromptForMessagingEndpointAsync #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gwharris7 merged 1 commit into from
Jun 4, 2026
Merged

Fix CS1998 async warning in PromptForMessagingEndpointAsync #443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/AllSubcommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,10 +960,10 @@ internal static async Task ExecuteMessagingEndpointStepAsync(SetupContext ctx)
/// Prompts for the messaging endpoint URL. Returns the entered HTTPS URL, or null to defer
/// (blank entry). The caller prints the section header and opens the indent scope.
/// </summary>
private static async Task<string?> PromptForMessagingEndpointAsync(SetupContext ctx)
private static Task<string?> PromptForMessagingEndpointAsync(SetupContext ctx)
{
if (ctx.NonInteractive)
return null;
return Task.FromResult<string?>(null);

ctx.Logger.LogInformation("The HTTPS URL where your deployed agent receives messages.");
ctx.Logger.LogInformation("Leave blank to configure it later, after you deploy the agent.");
Expand All @@ -975,15 +975,15 @@ internal static async Task ExecuteMessagingEndpointStepAsync(SetupContext ctx)
var entered = ConsoleHelper.ReadLineCancellable(ctx.CancellationToken)?.Trim();

if (string.IsNullOrWhiteSpace(entered))
return null;
return Task.FromResult<string?>(null);

if (Uri.TryCreate(entered, UriKind.Absolute, out var uri) && uri.Scheme == Uri.UriSchemeHttps)
return entered;
return Task.FromResult<string?>(entered);

ctx.Logger.LogWarning("Enter a valid HTTPS URL (e.g. https://my-agent.example.com/api/messages), or leave blank to skip.");
}

return null;
return Task.FromResult<string?>(null);
}

/// <summary>
Expand Down
Loading