Remove unnecessary Agent class patches from googleadk extension tests#169
Merged
JesuTerraz merged 2 commits intousers/jterrazas/google-adk-supportfrom Feb 6, 2026
Merged
Conversation
Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add Google ADK tooling extension to Agent365 SDK
Remove unnecessary Agent class patches from googleadk extension tests
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two test methods were patching the
Agentclass despite the implementation never instantiating or directly referencing it—only using the passed-inagentparameter.Changes
Agentpatch fromtest_add_tool_servers_exchanges_token_when_not_providedAgentpatch fromtest_add_tool_servers_uses_provided_tokenThe
Agentclass is imported for type hints but not used as a symbol in the implementation:This reduces unnecessary mocking surface and clarifies actual test dependencies.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.