Cleaned up terminology to align with the docs and C++ sample#46
Merged
mikebattista merged 1 commit intomasterfrom Apr 28, 2025
Merged
Cleaned up terminology to align with the docs and C++ sample#46mikebattista merged 1 commit intomasterfrom
mikebattista merged 1 commit intomasterfrom
Conversation
SohamDas2021
approved these changes
Apr 28, 2025
ptorr-msft
reviewed
Apr 28, 2025
Contributor
ptorr-msft
left a comment
ptorr-msft
left a comment
There was a problem hiding this comment.
Hmm I wonder if the rest of the sample can be cleaned up also (not your immediate problem though).
| @@ -169,7 +169,7 @@ private static bool registerSparsePackage(string externalLocation, string sparse | |||
|
|
|||
| deploymentOperation.Completed = (depProgress, status) => { opCompletedEvent.Set(); }; | |||
Contributor
There was a problem hiding this comment.
Huh I can't comment on non-changed lines but the way the async is done is bad (have a ManualResetEvent bla bla) - Can you switch to just await? Line 166 and others following it.
Contributor
Author
There was a problem hiding this comment.
Right this is how the package registration code was before I updated it. The initial priority is that code as it's what customers will copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.