Skip to content

Better agent diagnostic logging #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Better agent diagnostic logging #1012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions agent/src/main/java/com/microsoft/applicationinsights/agent/internal/MainEntryPoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ private MainEntryPoint() {
public static void premain(Instrumentation instrumentation, File agentJarFile) {
try {
startupLogger = initLogging(instrumentation, agentJarFile);
startupLogger.info("ApplicationInsights agent starting...");
start(instrumentation, agentJarFile);
startupLogger.info("ApplicationInsights agent started");
} catch (ThreadDeath td) {
throw td;
} catch (Throwable t) {
Expand Down
4 changes: 1 addition & 3 deletions agent/src/main/resources/ai.logback.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@
<pattern>%d{yyyy-MM-dd HH:mm:ss.SSS} %-5level %logger{36} - %msg%n</pattern>
</encoder>
</appender>
<logger name="org.glowroot.instrumentation" level="info" />
<logger name="com.microsoft.applicationinsights.agent.shadow" level="warn" />
<root level="info">
<root level="${applicationInsights.agent.logging.level:-error}">
<appender-ref ref="CONSOLE" />
</root>
</configuration>
2 changes: 2 additions & 0 deletions ...rc/main/java/com/microsoft/applicationinsights/web/internal/WebRequestTrackingFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,12 +189,14 @@ public void init(FilterConfig config) {
handler = new HttpServerHandler(new ApplicationInsightsServletExtractor(), webModulesContainer,
cleaners, telemetryClient);
if (AgentBridgeFactory.isAgentAvailable()) {
InternalLogger.INSTANCE.info("Agent is running");
agentBridge = AgentBridgeFactory.create(new SdkBridgeFactory() {
public SdkBridge create() {
return new SdkBridgeImpl(telemetryClient);
}
});
} else {
InternalLogger.INSTANCE.info("Agent is not running");
agentBridge = AgentBridgeFactory.create();
}
if (StringUtils.isNotEmpty(config.getFilterName())) {
Expand Down