Skip to content

Conversation

@littleaj
Copy link
Contributor

@littleaj littleaj commented Dec 7, 2017

The shadowJar was repackaging way more than it should. This fixes it.

Here's the gist:

  • By default, shadowJar repackages everything in the runtime configuration
  • runtime.extendsFrom compile i.e. runtime inherits all behaviors from compile.
  • Since provided was defined so compile inherited its behaviors, this created an unwanted transitive link causing everything defined as provided to be repackaged. Really, we just need these on the classpath (see changes to provided-configuration).

As a result of fixing what is repackaged:

  • Classes in :agent are no longer accessible and shouldn't be, hence the changes to java files.
  • Apache's poorly named method StringUtils.isEmpty actually does check for null :)

Also,

  • There's no reference to the Apache HttpClient in :web; only in its tests. So, that dependency was reclassified.

@littleaj littleaj added the Bug label Dec 7, 2017
@littleaj littleaj added this to the future milestone Dec 7, 2017
@littleaj littleaj self-assigned this Dec 7, 2017
@littleaj littleaj requested review from dhaval24 and grlima December 7, 2017 20:01
@dhaval24
Copy link
Contributor

dhaval24 commented Dec 7, 2017 via email

@littleaj
Copy link
Contributor Author

littleaj commented Dec 7, 2017

@dhaval24 Happy to help!

Before merging, I want to make sure the provided configuration is working properly across the board. Do you have a test application using spring to test against?

@dhaval24
Copy link
Contributor

dhaval24 commented Dec 7, 2017 via email

@dhaval24
Copy link
Contributor

#491 is related issue. @littleaj I believe this PR fixes that too? Correct me if I am wrong.

@littleaj littleaj modified the milestones: future, 2.0.0 Dec 12, 2017
@littleaj littleaj merged commit 98d6e1b into master Dec 12, 2017
@littleaj littleaj deleted the fix_shadow_build branch December 12, 2017 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants