Ensure the repository functions return the right types#273
Merged
Conversation
TessFerrandez
requested review from
deniscep,
msebragge,
sachinkundu and
tompaana
Unit Test Results 1 files 1 suites 2s ⏱️ Results for commit b656f4d. |
msebragge
approved these changes
Jun 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is being addressed
Currently the repository functions return dictionaries when they say they return Workspace or ResourceTemplate objects. This PR casts them to the expected return type so that we get validation exceptions at the repository level if the data coming back from the db is malformed. (So that those errors are catchable later)
How is this addressed
This is a prerequisite for #213