Correlation ID to Service Bus and logs#334
Merged
Merged
Conversation
Unit Test Results 1 files 1 suites 2s ⏱️ Results for commit ca98926. ♻️ This comment has been updated with latest results. |
4 tasks
Lybecker
approved these changes
Jun 23, 2021
Member
Lybecker
left a comment
Lybecker
left a comment
There was a problem hiding this comment.
Looks good for now. Right now the developer has to remember to include the correlation id to each log method.
In the future I would be better with tighter integration with OpenCensus
- Accepting W3C Trace-Context from client HTTP requests
- creating span for each component (API, Resource Processer ...)
- store the Span Context in contextvars
- Make the application map work in App Insights
- Seamless propagate SpanContext through Azure Service Bus
…tion-id-for-logs # Conflicts: # management_api_app/tests/test_api/test_routes/test_workspaces.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #271
What is being addressed
Adds correlation ID for workspace deployment to Service Bus messages and manual injects that in logs.
How is this addressed