Skip to content

add app info to workspace request - NOTE: depends on #320#354

Merged
TessFerrandez merged 11 commits into
developfrom
tessferrandez/add-app-to-workspace-request
Jun 24, 2021
Merged

add app info to workspace request - NOTE: depends on #320#354
TessFerrandez merged 11 commits into
developfrom
tessferrandez/add-app-to-workspace-request

Conversation

@TessFerrandez
Copy link
Copy Markdown
Member

PR for issue #306

What is being addressed

  • User is required to add AAD app info to POST /workspaces for authentication
  • App info is validated to ensure it exists and contains the right roles
  • SP and role IDs are added to the workspace request to be used for user/workspace lookup

How is this addressed

  • New class AccessService - this will act as an interface (abstract base class) for all AccessServices (if someone wants to change auth method)
  • Implementation of AADAccessService that validates the auth_config (e.g. app - and returns relevant info to be stored in workspace request)
  • POST Workspaces input takes auth_config which in the case of the AAD provider is app_id -- this is intentionally a dict so it can be different for different auth providers
  • POST Workspaces calls validation/extraction - this class in turn picks the relevant AccessService based on the provider supplied
  • Relevant tests updated
  • Tests added for AccessService

NOTE: This PR depends on ENV VARS that will be added by @askew as part of #320

Closes #306

@TessFerrandez TessFerrandez added api Composition Service API auth Authentication and authorization labels Jun 23, 2021
@TessFerrandez TessFerrandez self-assigned this Jun 23, 2021
@TessFerrandez TessFerrandez linked an issue Jun 23, 2021 that may be closed by this pull request
5 tasks
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 23, 2021

Unit Test Results

  1 files    1 suites   2s ⏱️
59 tests 59 ✔️ 0 💤 0 ❌

Results for commit 4b39cb0.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Member

@tompaana tompaana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some documentation, but otherwise looks nice and clean!

Comment thread management_api_app/core/config.py
@TessFerrandez TessFerrandez merged commit 3781f7a into develop Jun 24, 2021
@TessFerrandez TessFerrandez deleted the tessferrandez/add-app-to-workspace-request branch June 24, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Composition Service API auth Authentication and authorization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update POST /workspace to accept an auth_config

2 participants