Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Aug 29, 2025

This PR enables TRE administrators to update workspace shared storage quotas through the TRE interface without requiring workspace recreation.

Problem

Currently, the shared_storage_quota field in workspace templates is not marked as updateable, preventing users from modifying storage quotas through the TRE interface. This has caused issues where workspaces run out of their default 500GB allocation and administrators cannot easily increase the quota.

While Azure supports in-place quota updates for storage file shares, the TRE template schema was missing the "updateable": true flag for this field.

Solution

Added the "updateable": true property to the shared_storage_quota field in the workspace base template schema. The underlying infrastructure already supports this operation:

  • Terraform uses azapi_resource with Azure Storage API 2023-05-01
  • The shareQuota property directly maps to the variable
  • No lifecycle blocks prevent updates
  • Azure Storage file shares support quota modifications without share recreation

Changes

  1. template_schema.json: Added "updateable": true to shared_storage_quota field
  2. porter.yaml: Bumped version from 2.4.0 to 2.5.0 (minor version for new functionality)
  3. CHANGELOG.md: Added enhancement and component version entries

Impact

  • TRE administrators can now adjust workspace storage quotas from the UI
  • No workspace recreation required for quota changes
  • Resolves immediate need for workspaces exceeding default allocation
  • Consistent with other updateable fields like app_service_plan_sku and enable_airlock

Technical Notes

When quota is decreased below current usage, Azure gracefully handles this by allowing the operation but preventing new file uploads until usage drops below the new limit.

Fixes #4314.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: marrobi <17089773+marrobi@users.noreply.github.com>
Copilot AI changed the title [WIP] Updating quota for workspace shared storage Make workspace shared storage quota updateable Aug 29, 2025
Copilot AI requested a review from marrobi August 29, 2025 08:23
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrobi marrobi marked this pull request as ready for review September 15, 2025 15:22
@github-actions
Copy link

github-actions bot commented Sep 15, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit db28c85.

♻️ This comment has been updated with latest results.

@marrobi marrobi requested a review from a team as a code owner November 25, 2025 17:18
@marrobi marrobi enabled auto-merge (squash) November 25, 2025 17:19
@marrobi
Copy link
Member

marrobi commented Nov 25, 2025

/test-force-approve db28c85

Not covered by tests

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit db28c85)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 651b7b2 into main Nov 25, 2025
15 checks passed
@marrobi marrobi deleted the copilot/fix-4314 branch November 25, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating quota for workspace shared storage

4 participants