Skip to content

Add parameter to payload in e2etests/conftest to disable service vaul…#4921

Open
maxmartin-cgi wants to merge 6 commits into
microsoft:mainfrom
maxmartin-cgi:service-vault-fix
Open

Add parameter to payload in e2etests/conftest to disable service vaul…#4921
maxmartin-cgi wants to merge 6 commits into
microsoft:mainfrom
maxmartin-cgi:service-vault-fix

Conversation

@maxmartin-cgi
Copy link
Copy Markdown

…t backup in test environments

Resolves #4920

What is being addressed

E2E tests failing to run due to bug in recovery service vaults.

How is this addressed

Added parameter to "properties" payload in e2etests/conftest.py to disable backup (currently enabled by default)
payload = { "templateName": template_name, "properties": { "display_name": f"E2E {description} workspace ({auth_type} AAD)", "description": f"{template_name} test workspace for E2E tests", "auth_type": auth_type, "address_space_size": "small", "enable_backup": False } }

Copilot AI review requested due to automatic review settings June 2, 2026 09:13
@maxmartin-cgi maxmartin-cgi requested a review from a team as a code owner June 2, 2026 09:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates E2E test workspace provisioning to explicitly disable backups when creating (or retrieving) test workspaces.

Changes:

  • Adds enable_backup: False to the test workspace creation payload.
  • Fixes the JSON/dict formatting by adding a trailing comma after address_space_size.

@github-actions github-actions Bot added the external PR from an external contributor label Jun 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Unit Test Results

673 tests   673 ✅  7s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 7e6dcf1.

♻️ This comment has been updated with latest results.

@rudolphjacksonm
Copy link
Copy Markdown
Collaborator

/test-extended d45b558

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/26811484684 (with refid ac107ffc)

(in response to this comment from @rudolphjacksonm)

@rudolphjacksonm
Copy link
Copy Markdown
Collaborator

/test-extended 904c614

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/26878311975 (with refid ac107ffc)

(in response to this comment from @rudolphjacksonm)

@maxmartin-cgi
Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree company="CGI"

@rudolphjacksonm
Copy link
Copy Markdown
Collaborator

/test-extended fc654b6

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/26887373327 (with refid ac107ffc)

(in response to this comment from @rudolphjacksonm)

@rudolphjacksonm
Copy link
Copy Markdown
Collaborator

/test-destroy-env

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Destroying PR test environment (RG: rg-treac107ffc)... (run: https://github.com/microsoft/AzureTRE/actions/runs/26956600493)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

PR test environment destroy complete (RG: rg-treac107ffc)

@rudolphjacksonm
Copy link
Copy Markdown
Collaborator

/test-extended 1ea17b4

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/26959469098 (with refid ac107ffc)

(in response to this comment from @rudolphjacksonm)

@rudolphjacksonm
Copy link
Copy Markdown
Collaborator

@copilot bump the api version so container image can be built

@rudolphjacksonm
Copy link
Copy Markdown
Collaborator

/test-extended 7e6dcf1

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/27004507579 (with refid ac107ffc)

(in response to this comment from @rudolphjacksonm)

@rudolphjacksonm
Copy link
Copy Markdown
Collaborator

/test-destroy-env

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

Destroying PR test environment (RG: rg-treac107ffc)... (run: https://github.com/microsoft/AzureTRE/actions/runs/27005457222)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

PR test environment destroy complete (RG: rg-treac107ffc)

@rudolphjacksonm
Copy link
Copy Markdown
Collaborator

/test-extended 1ea17b4

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

🤖 pr-bot 🤖

⚠️ The specified SHA 1ea17b4 is not the latest commit on the PR. Please validate the latest commit and re-run /test

(in response to this comment from @rudolphjacksonm)

@rudolphjacksonm
Copy link
Copy Markdown
Collaborator

/test-extended 7e6dcf1

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/27005962244 (with refid ac107ffc)

(in response to this comment from @rudolphjacksonm)

@rudolphjacksonm
Copy link
Copy Markdown
Collaborator

/test-extended 7e6dcf1

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/27007145453 (with refid ac107ffc)

(in response to this comment from @rudolphjacksonm)

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 6, 2026

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/27007145453 (with refid ac107ffc)

(in response to this comment from @rudolphjacksonm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from an external contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recovery services vaults stopping CI/CD tests from running

3 participants