Conversation
onbuyuka
approved these changes
Aug 25, 2025
aholstrup1
approved these changes
Aug 25, 2025
miljance
pushed a commit
to miljance/BCApps
that referenced
this pull request
Oct 22, 2025
#### Summary <!-- Provide a general summary of your changes --> The test was failing in US localization because it is using `USD` currency in test data, and that will have complications in US localization. This is not the first time we bump into this problem... Fix by using a currency that we don't have in our build system. Don't think there is a more elegant way to handle this, guess we will just have to remember not to use a currency that we have in our build. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#598388](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/598388)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The test was failing in US localization because it is using
USDcurrency in test data, and that will have complications in US localization.This is not the first time we bump into this problem... Fix by using a currency that we don't have in our build system. Don't think there is a more elegant way to handle this, guess we will just have to remember not to use a currency that we have in our build.
Work Item(s)
Fixes AB#598388