Skip to content

[Bug]: Support for Mandatory Item Variants in Subscription Billing Module [SubscriptionBilling]#4662

Merged
djukicmilica merged 10 commits intomicrosoft:mainfrom
miljance:SupportForMandatoryVariantsInSubscriptionBillingModule
Sep 23, 2025
Merged

[Bug]: Support for Mandatory Item Variants in Subscription Billing Module [SubscriptionBilling]#4662
djukicmilica merged 10 commits intomicrosoft:mainfrom
miljance:SupportForMandatoryVariantsInSubscriptionBillingModule

Conversation

@miljance
Copy link
Copy Markdown
Contributor

@miljance miljance commented Sep 2, 2025 •
edited by github-actions bot
Loading

Summary

  1. Variant Code is now selectable when extending Subscription Customer Contract
  2. Variant Code can be made visible on a Customer Contract Line Subpage and can be changed directly in the Contract Line
  3. Similar to a sales document, Variant Code is rendered with a red star if Variant Code should be entered.
  4. A test testing the update of a Service Object when a field is changed on a Customer Contract Line has been extended.

Work Item(s)

Fixes #4400
Fixes AB#604193

@miljance miljance requested a review from a team as a code owner September 2, 2025 13:08
@github-actions github-actions bot added the From Fork Pull request is coming from a fork label Sep 2, 2025
@miljance
Copy link
Copy Markdown
Contributor Author

miljance commented Sep 2, 2025

@anjajanic Can you do a code review please?

pri-kise
pri-kise suggested changes Sep 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@pri-kise pri-kise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't see any check on the variant blocked property.
e.g. when a variant is selected.
Is this intentional?
I know that this feature is still new for the variant (https://github.com/microsoft/BusinessCentralApps/pull/351).

@JesperSchulz JesperSchulz added the Finance GitHub request for Finance area label Sep 3, 2025
@miljance
Copy link
Copy Markdown
Contributor Author

miljance commented Sep 3, 2025

I couldn't see any check on the variant blocked property. e.g. when a variant is selected. Is this intentional? I know that this feature is still new for the variant (microsoft/BusinessCentralApps#351).

Thanks, I wasn't aware this change coming in. I guess I would like to have it aligned. I will have another round then.

@miljance miljance requested a review from pri-kise September 3, 2025 14:58
@miljance miljance requested a review from pri-kise September 4, 2025 09:45
pri-kise
pri-kise suggested changes Sep 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@pri-kise pri-kise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked again some lines above and below your changes, since I was looking for the logic that updates the description with ItemVariant Translation (or the Description).
Maybe this code is already and I only don't see it.
Since this wasn't part of the original change, this don't need to be changed with this PR.
I'm only asking questions.

@miljance miljance requested a review from pri-kise September 5, 2025 15:48
@miljance miljance requested a review from duichwer September 8, 2025 07:40
@miljance miljance force-pushed the SupportForMandatoryVariantsInSubscriptionBillingModule branch from ce6d5c2 to 55b3c31 Compare September 9, 2025 09:09
@miljance miljance requested a review from pri-kise September 15, 2025 11:52
djukicmilica
djukicmilica previously approved these changes Sep 16, 2025
View reviewed changes
@djukicmilica djukicmilica enabled auto-merge (squash) September 17, 2025 17:29
djukicmilica
djukicmilica previously approved these changes Sep 17, 2025
View reviewed changes
auto-merge was automatically disabled September 18, 2025 12:34

Head branch was pushed to by a user without write access

@djukicmilica djukicmilica enabled auto-merge (squash) September 18, 2025 13:02
@github-actions github-actions bot added the Linked Issue is linked to a Azure Boards work item label Sep 22, 2025
@github-actions github-actions bot added this to the Version 28.0 milestone Sep 22, 2025
@djukicmilica djukicmilica merged commit 9392f8a into microsoft:main Sep 23, 2025
32 of 37 checks passed
miljance added a commit to miljance/BCApps that referenced this pull request Oct 22, 2025
@miljance
[Bug]: Support for Mandatory Item Variants in Subscription Billing Mo…
2a0cdbb 
…dule [SubscriptionBilling] (microsoft#4662)

<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->


1. Variant Code is now selectable when extending Subscription Customer
Contract
2. Variant Code can be made visible on a Customer Contract Line Subpage
and can be changed directly in the Contract Line
3. Similar to a sales document, Variant Code is rendered with a red star
if Variant Code should be entered.
4. A test testing the update of a Service Object when a field is changed
on a Customer Contract Line has been extended.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes microsoft#4400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djukicmilica djukicmilica djukicmilica approved these changes

@AndersLarsenMicrosoft AndersLarsenMicrosoft AndersLarsenMicrosoft approved these changes

@duichwer duichwer Awaiting requested review from duichwer

@pri-kise pri-kise Awaiting requested review from pri-kise

Assignees

@djukicmilica djukicmilica

Labels

Finance GitHub request for Finance area From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item

Projects

None yet

Milestone

Version 28.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Support for Mandatory Item Variants in Subscription Billing Module [SubscriptionBilling]

6 participants

@miljance @duichwer @djukicmilica @AndersLarsenMicrosoft @pri-kise @JesperSchulz