Skip to content

Clean up app from symbols folder if it already exists before compilation#4819

Merged
aholstrup1 merged 3 commits intomainfrom
private/aholstrup/remove_default_app
Sep 19, 2025
Merged

Clean up app from symbols folder if it already exists before compilation#4819
aholstrup1 merged 3 commits intomainfrom
private/aholstrup/remove_default_app

Conversation

@aholstrup1
Copy link
Copy Markdown
Contributor

@aholstrup1 aholstrup1 commented Sep 19, 2025

Summary

When we compile apps in clean mode we start by compiling the app in "default" mode i.e. without preprocessor symbols. However, in some cases the folder that holds the apps built in "default" mode may already contain the app we're about to build. To avoid issues, we can remove the app file before we recompile in default mode to ensure that the .app file was built without preprocessor symbols etc.

Work Item(s)

Related to AB#603840

@aholstrup1 aholstrup1 requested a review from a team as a code owner September 19, 2025 07:39
@github-actions github-actions bot added the Build: scripts & configs Build scripts and configuration files label Sep 19, 2025
@github-actions github-actions bot added this to the Version 28.0 milestone Sep 19, 2025
@aholstrup1 aholstrup1 enabled auto-merge (squash) September 19, 2025 09:17
@aholstrup1 aholstrup1 merged commit 78d4224 into main Sep 19, 2025
29 checks passed
@aholstrup1 aholstrup1 deleted the private/aholstrup/remove_default_app branch September 19, 2025 13:27
miljance pushed a commit to miljance/BCApps that referenced this pull request Oct 22, 2025
…ion (microsoft#4819)

<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
When we compile apps in clean mode we start by compiling the app in
"default" mode i.e. without preprocessor symbols. However, in some cases
the folder that holds the apps built in "default" mode may already
contain the app we're about to build. To avoid issues, we can remove the
app file before we recompile in default mode to ensure that the .app
file was built without preprocessor symbols etc.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Related to
[AB#603840](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/603840)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build: scripts & configs Build scripts and configuration files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants