Add gate for duplicate app and object ids #4867
Merged
aholstrup1 merged 13 commits intomainfrom Sep 25, 2025
Merged
Conversation
…te/aholstrup/objectidtests
…microsoft/BCApps into private/aholstrup/objectidtests
github-actions
bot
added
Build: Automation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mazhelez
previously approved these changes
Sep 24, 2025
mazhelez
approved these changes
Sep 25, 2025
ankosiorek
approved these changes
Sep 25, 2025
miljance
pushed a commit
to miljance/BCApps
that referenced
this pull request
Oct 22, 2025
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> From time to time we see failures in the uptake due to issues with the object ids or app ids. Internally, we require that * App IDs are unique * All test objects fall within a certain range * Object ids are unique This PR adds a gate for that in BCApps. The last-mentioned gate currently only validates this within the code in BCApps. In the future, we could look into downloading e.g. the base application source code prior to running the check so we can also validate that we're not reusing object ids used in the base application. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#591348](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/591348)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From time to time we see failures in the uptake due to issues with the object ids or app ids. Internally, we require that
This PR adds a gate for that in BCApps. The last-mentioned gate currently only validates this within the code in BCApps. In the future, we could look into downloading e.g. the base application source code prior to running the check so we can also validate that we're not reusing object ids used in the base application.
Work Item(s)
Fixes AB#591348