E-Document Header History - change to modify if exists#5446
Merged
Groenbech96 merged 1 commit intomainfrom Nov 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the vendor assignment history tracking mechanism to prevent duplicate records. The changes enable updating existing vendor assignment history entries instead of creating duplicates when the same vendor information (VAT ID, GLN, Address, Company Name) is already tracked.
- Added a secondary key to enable efficient lookup of existing vendor assignment history records
- Modified the insertion logic to update existing records or insert new ones based on whether a matching history entry exists
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| EDocVendorAssignHistory.Table.al | Adds a secondary key (Key2) on vendor identification fields to support efficient lookup during upsert operations |
| EDocPurchaseHistMapping.Codeunit.al | Implements upsert logic to prevent duplicate vendor assignment history records by checking for existing entries and updating them instead of always inserting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../W1/EDocument/App/src/Processing/Import/Purchase/History/EDocPurchaseHistMapping.Codeunit.al
Show resolved
Hide resolved
.../W1/EDocument/App/src/Processing/Import/Purchase/History/EDocPurchaseHistMapping.Codeunit.al
Show resolved
Hide resolved
darjoo
reviewed
Nov 10, 2025
.../W1/EDocument/App/src/Processing/Import/Purchase/History/EDocPurchaseHistMapping.Codeunit.al
Show resolved
Hide resolved
.../W1/EDocument/App/src/Processing/Import/Purchase/History/EDocPurchaseHistMapping.Codeunit.al
Show resolved
Hide resolved
darjoo
approved these changes
Nov 10, 2025
onbuyuka
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We dont want to keep inserting on entries we have seen before. Just update the Purch Inv Header link to the new sample.
Summary
Work Item(s)
Fixes AB#612575