[E-Document] Introduce eligibility interface to allow control of when to export#5489
Conversation
Groenbech96
dismissed stale reviews from aholstrup1 and nikolakukrika
via
05c5e0b
gggdttt
left a comment
gggdttt
left a comment
There was a problem hiding this comment.
Looks good. Really like your new design
|
Please note that Jesper has previously promised this to be released in BC27.1 on microsoft/ALAppExtensions#28877. I can see that the issue is now labeled with 28.0! I expect this to be part of 27.2. Thx |
|
@Groenbech96 and I am still missing feedback on my comment from 3 weeks ago regarding the release: #5489 (comment) |
|
@Groenbech96 and @JesperSchulz - I am still missing your feedback on the release schedule. Please remember that @JesperSchulz originally promised this feature to be released with BC27.1 |
|
@kasperdj, I promised to backport microsoft/ALAppExtensions#28877 - and I did! Those changes have been released with 27.1. |
… to export (#5489) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> Moving code from GetTypeFromPostedSourceDocument to single function GetTypeFromSourceDocument, that now converts both posted and non posted types. IsDocumentTypeSupported is now called IsDocumentSupported, and checks first the type using the GetTypeFromSourceDocument, and then also checks the ShouldExport impl. This works for both check and create methods. Only check when you want to export. Add default enum impl on service as a field, that can be set for a given service record, allowing control for partners to determine if documents should be exported or not. Fixes [AB#612844](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/612844) --------- Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com>
|
@JesperSchulz please do that. Thx! |
7 participants
Summary
Moving code from GetTypeFromPostedSourceDocument to single function GetTypeFromSourceDocument, that now converts both posted and non posted types.
IsDocumentTypeSupported is now called IsDocumentSupported, and checks first the type using the GetTypeFromSourceDocument, and then also checks the ShouldExport impl. This works for both check and create methods.
Only check when you want to export.
Add default enum impl on service as a field, that can be set for a given service record, allowing control for partners to determine if documents should be exported or not.
Fixes AB#612844