Skip to content

Fix pagination for Azure File Share #5502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JesperSchulz merged 1 commit into from
Nov 14, 2025
Merged

Fix pagination for Azure File Share #5502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...File Storage - Azure File Service Connector/App/src/ExtFileShareConnectorImpl.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,12 +416,16 @@ codeunit 4570 "Ext. File Share Connector Impl" implements "External File Storage
AFSOptionalParameters.Marker(FilePaginationData.GetMarker());
end;

local procedure ValidateListingResponse(var FilePaginationData: Codeunit "File Pagination Data"; var AFSOperationResponse: Codeunit "AFS Operation Response")
local procedure ValidateListingResponse(var FilePaginationData: Codeunit "File Pagination Data"; var AFSDirectoryContent: Record "AFS Directory Content"; var AFSOperationResponse: Codeunit "AFS Operation Response")
begin
if not AFSOperationResponse.IsSuccessful() then
Error(AFSOperationResponse.GetError());

FilePaginationData.SetEndOfListing(true);
if not AFSDirectoryContent.FindLast() then
FilePaginationData.SetEndOfListing(true);

FilePaginationData.SetMarker(AFSDirectoryContent."Next Marker");
FilePaginationData.SetEndOfListing(AFSDirectoryContent."Next Marker" = '');
end;

local procedure GetDirectoryContent(var AccountId: Guid; var PassedPath: Text; var FilePaginationData: Codeunit "File Pagination Data"; var AFSDirectoryContent: Record "AFS Directory Content")
Expand All @@ -437,7 +441,7 @@ codeunit 4570 "Ext. File Share Connector Impl" implements "External File Storage
Path := CopyStr(PassedPath, 1, MaxStrLen(Path));
AFSOperationResponse := AFSFileClient.ListDirectory(Path, AFSDirectoryContent, AFSOptionalParameters);
PassedPath := Path;
ValidateListingResponse(FilePaginationData, AFSOperationResponse);
ValidateListingResponse(FilePaginationData, AFSDirectoryContent, AFSOperationResponse);
end;

local procedure SetReadySAS(var StorageServiceAuthorization: Codeunit "Storage Service Authorization"; Secret: SecretText): Interface System.Azure.Storage."Storage Service Authorization"
Expand Down
Loading