[27.2] Agent - Duplicate user name is generated if one of the agents is deleted#5683
Closed
nikolakukrika wants to merge 104 commits intomainfrom
Closed
[27.2] Agent - Duplicate user name is generated if one of the agents is deleted#5683nikolakukrika wants to merge 104 commits intomainfrom
nikolakukrika wants to merge 104 commits intomainfrom
Conversation
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Final integration from main to 27.x #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Related to [AB#597864](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/597864) --------- Co-authored-by: Quentin Tresontani <31541422+qutreson@users.noreply.github.com> Co-authored-by: Onat Buyukakkus <55088871+onbuyuka@users.noreply.github.com> Co-authored-by: business-central-bot[bot] <205154211+business-central-bot[bot]@users.noreply.github.com> Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Increment version number to 27.1 #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Related to [AB#597872](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/597872) --------- Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
This pull request backports #4558 to releases/27.x Related to [AB#598707](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/598707)
…ase/latest (#4552) This PR contains the following changes: - Update BCArtifact version. New value: 27.0.38571.0 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) --------- Co-authored-by: mazhelez <mazhelez@users.noreply.github.com> Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
…om a single place (#4579) This pull request backports #4501 to releases/27.x Fixes [AB#598713](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/598713)
…4581) This pull request backports #4516 to releases/27.x Fixes [AB#598712](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/598712)
…irectory.App.Props.json (#4585) This pull request backports #4559 to releases/27.x Fixes [AB#598707](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/598707)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Add CLEAN28 to AL-Go-Settings.json #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Related to [AB#597870](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/597870)
…emplate using latest setup table (#4557) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Port from #4507 #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#593746](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/593746)
This pull request backports #4512 to releases/27.x Fixes [AB#598726](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/598726) Fixes [AB#598728](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/598728) Fixes [AB#598730](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/598730) Fixes [AB#598743](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/598743)
#### Summary Adding support for selecting the language from the agent setup card #### Work Item(s) Fixes [AB#596383](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/596383)
…861 (+ 1 more update(s)) (#4646) This PR contains the following changes: - Update app baselines package version. New value: 27.0.38460.38861 - Update translation package version. New value: 27.1.25245.2 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
This pull request backports #4617 to releases/27.x Fixes [AB#599061](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/599061)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Port from #4661 #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#599346](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/599346)
…4669) #### Summary Add support to ignore attachments being processed by agent #### Work Item(s) [AB#562490](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/562490) Co-authored-by: Qasim Ikram <qaikram@microsoft.com>
…not enabled (#4657) This pull request backports #4628 to releases/27.x Fixes [AB#599307](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/599307)
…ements (#4655) This pull request backports #4629 to releases/27.x Fixes [AB#599305](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/599305)
…lines (#4689) This pull request backports #4626 to releases/27.x Fixes [AB#599869](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/599869)
When Subscription Billing app creates a new billing document it validates the vendor number and posting date. Then the IRS forms app, which is the US specific app, not related to subscription billing, run an update of certain fields related to this app. This kind of update in the IRS forms app from the other side triggers the Subscription billing app code - the CreatePurchaseHeaderForVendorNo procedure. This procedure throws the following error: You cannot make this change because the document is linked to a contract. If you still want to change the field, first delete this document and then make the change to the contract. This procedure has a list of fields for exclusion. It would be great to add IRS forms app fields to the exclusion list, but that is not possible unless i create a dependency between these two apps, which does not make any sense. The other approach which i eventually chose is to skip calling the CreatePurchaseHeaderForVendorNo when i change the vendor number pr posting date. To me it sounds much better as we keep the procedure untouched, so we continue to call it whenever some user changes this value in the document. But if we validate the posting date through the code in the CreateBillingDocuments codeunit, we can skip this check. [AB#599229](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/599229)
…233 (+ 1 more update(s)) (#4725) This PR contains the following changes: - Update app baselines package version. New value: 27.0.38460.39233 - Update translation package version. New value: 27.1.25252.1 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
Fixes [AB#571288](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/571288) Co-authored-by: Vasil Iliev <vasililiev@users.noreply.github.com> Co-authored-by: Vasil Iliev <vailiev@microsoft.com>
#### Summary Allow attachments to be marked as ignored # #### Work Item(s) [AB#562490](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/562490) --------- <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes # Co-authored-by: Qasim Ikram <qaikram@microsoft.com>
…word since SecretTexts cannot be compared in Cloud - missing capability in 27 compared to 26! (#4751) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Backport of #4654 #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#602446](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/602446) Co-authored-by: bc4all <104026807+bc4all@users.noreply.github.com>
…526 (+ 1 more update(s)) (#4771) This PR contains the following changes: - Update app baselines package version. New value: 27.0.38460.39526 - Update translation package version. New value: 27.1.25259.3 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> This is a backport of the PR: #4467 from main (28.0) to 27.x #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes #4186 --------- Co-authored-by: Jesper Schulz-Wedde <JesperSchulz@users.noreply.github.com>
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> [27.x] Disable tests in Contract Renewal Test to unblock CI/CD https://github.com/microsoft/BCApps/actions/runs/17848137827 #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#603826](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/603826)
…844 (+ 1 more update(s)) (#4840) This PR contains the following changes: - Update app baselines package version. New value: 27.0.38460.39844 - Update translation package version. New value: 27.1.25266.4 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
…permis… (#4855) "Add Related Fields" permission is not part of any user permission sets , therefore uptake is cubersome since admins need to know about this permission and assign it to the users. The PM decision is to include "Add Related Fields" permission in Basic permision set. Fixes [AB#604298](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/604298)
…rency to avoid fake "Processing" email block email sending (#4894) This pull request backports #4820 to releases/27.x Fixes [AB#606062](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/606062)
…226 (+ 1 more update(s)) (#4924) This PR contains the following changes: - Update app baselines package version. New value: 27.0.38460.40226 - Update translation package version. New value: 27.1.25273.3 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
Disable VAT check in test, as it blocks CZ uptake of app. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#611626](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/611626) Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com>
…AndFieldsNoByType *1 (#5385) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> This is a backport of PR: #5173 from main (28.0) to 27.x #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes #5172 Fixes [AB#613107](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/613107)
…onalInvoiceLine (#5480) #### Summary Make parameter `SalesLine` of event `OnAfterCreateAdditionalInvoiceLine` useful by returing the newly created attached sales line. Backport of #5380 #### Work Item(s) Fixes #5304 Fixes [AB#613118](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/613118)
…312 (#5527) This PR contains the following changes: - Update app baselines package version. New value: 27.1.41698.42312 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
This pull request backports #5495 to releases/27.x Fixes [AB#613378](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/613378)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#610611](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/610611) --------- Co-authored-by: wenjiefan <wenjiefan@microsoft.com>
#### Summary This is a Backport of PR #5388 from main (28.0) to 27.x #### Work Item(s) Fixes #5374 [AB#613296](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/613296)
… Agent Card permissions if permissions span multiple companies (#5586) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#603146](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/603146) Backports of the following: [Agent] Only show company in Agent Card permissions if permissions span multiple companies (#4549) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> To reduce the risk of potential misconfiguration of agents, do not show the company when the agent has permissions in only one company. A toggle is added to show the company if needed. <img width="1754" height="221" alt="image" src="https://github.com/user-attachments/assets/f1fe14c3-6b1e-4280-82e2-c43196413a10" /> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#593056](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/593056) --------- Co-authored-by: Quentin Tresontani <31541422+qutreson@users.noreply.github.com>
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guidelines below * https://github.com/microsoft/BCApps/Contributing.md --> ### Summary This pull request extends the System Application Translation module with a new public API for programmatic retrieval of translation data, addressing the requirements of partners and ISVs for custom translation workflows and data integration scenarios. **Current Gap:** The existing Translation module API lacks bulk retrieval capabilities needed for: - Adding translation to the custom tables and workflows - Exporting translations for external processing ### Technical Approach Introduces a read-only query API following established System Application patterns, returning results via a temporary buffer table to ensure no database impact and maintain performance standards. ### API Design #### Public Procedure: `GetTranslations` **Location:** `codeunit 3711 "Translation"` (System Application) **Signature:** ```al procedure GetTranslations(RecVariant: Variant; FieldId: Integer; var TranslationBuffer: Record "Translation Buffer"): Boolean ``` **Parameters:** | Parameter | Type | Description | |-----------|------|-------------| | RecVariant | Variant | Source record (supports Record, RecordRef, or RecordId) | | FieldId | Integer | Field number to query (0 = all fields) | | TranslationBuffer | Record "Translation Buffer" (var) | Output buffer populated with results | **Returns:** `Boolean` - True if translations found, False otherwise **Design Rationale:** - **Variant parameter** - Maintains consistency with existing `Translation.Set()` and `Translation.Get()` APIs - **Temporary buffer output** - Enables efficient batch processing without database writes - **Boolean return** - Provides explicit success/failure indication for error handling - **Zero FieldId convention** - Allows bulk retrieval across all translated fields #### Work Item(s) Fixes #5434 Fixes [AB#613845](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/613845) Co-authored-by: Divesh Bora <dbora@aptean.com>
…sales line for27.x (#5386) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes #5286 Fixes [AB#612606](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/612606)
…623 (+ 1 more update(s)) (#5603) This PR contains the following changes: - Update app baselines package version. New value: 27.1.41698.42623 - Update translation package version. New value: 27.2.25328.3 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <aholstrup1@users.noreply.github.com>
This pull request backports #5146 to releases/27.x Fixes [AB#612892](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/612892)
…payment method mapping (#5636) This pull request backports #5452 to releases/27.x Fixes [AB#614464](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/614464)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Allow agent admins to access the agent cards without requiring SUPER. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#604144](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/604144)
#### Summary Backporting Agent App changes to 27.x #### Work Item(s) Fixes [AB#614196](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/614196) --------- Co-authored-by: Sotiris Dragonas <36576941+BazookaMusic@users.noreply.github.com> Co-authored-by: Sotiris Dragonas <sodragon@microsoft.com> Co-authored-by: Quentin Tresontani <31541422+qutreson@users.noreply.github.com>
github-actions
bot
added
Build: Automation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
###Summary
Duplicate user name is generated if one of the agents is deleted
Work Item(s)
Fixes AB#615177