-
Notifications
You must be signed in to change notification settings - Fork 305
[Shopify] Variant option extensibility #6013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tVisionDeb
wants to merge
1
commit into
microsoft:main
Choose a base branch
from
tVisionDeb:feature/5867-shopify-event
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for Shopify variants
onbuyuka
approved these changes
Jan 5, 2026
Contributor
|
@tVisionDeb build fails due to compilation errors: |
JesperSchulz
approved these changes
Jan 6, 2026
JesperSchulz
reviewed
Jan 6, 2026
| /// <param name="ItemUnitofMeasure">The source Item Unit of Measure record.</param> | ||
| /// <param name="Shop">The Shopify shop context.</param> | ||
| [IntegrationEvent(false, false)] | ||
| local procedure OnAfterFillInProductVariantDataFromVariant(var ShopifyVariant: Record "Shpfy Variant"; Item: Record Item; ItemVariant: Record "Item Variant"; ItemUnitofMeasure: Record "Item Unit of Measure"; Shop: Record "Shpfy Shop") |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this procedure cannot be local, as it's called from a different codeunit. Maybe you meant "internal"?
Suggested change
| local procedure OnAfterFillInProductVariantDataFromVariant(var ShopifyVariant: Record "Shpfy Variant"; Item: Record Item; ItemVariant: Record "Item Variant"; ItemUnitofMeasure: Record "Item Unit of Measure"; Shop: Record "Shpfy Shop") | |
| internal procedure OnAfterFillInProductVariantDataFromVariant(var ShopifyVariant: Record "Shpfy Variant"; Item: Record Item; ItemVariant: Record "Item Variant"; ItemUnitofMeasure: Record "Item Unit of Measure"; Shop: Record "Shpfy Shop") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AL: Apps (W1)
Add-on apps for W1
From Fork
Pull request is coming from a fork
Integration
GitHub request for Integration area
Linked
Issue is linked to a Azure Boards work item
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5867
Shopify Connector: Custom Variant Naming for Item Variants
BC Idea: https://experience.dynamics.com/ideas/idea/?ideaid=244315e3-d8bb-f011-aa43-7c1e52a6c1f4
Adds logic to recalculate and set custom variant names after standard data fill-in, using a new event (OnAfterFillInProductVariantDataFromVariant).
Fixes AB#617325