Skip to content

Conversation

@tVisionDeb
Copy link

@tVisionDeb tVisionDeb commented Jan 2, 2026

Fixes #5867

Shopify Connector: Custom Variant Naming for Item Variants

BC Idea: https://experience.dynamics.com/ideas/idea/?ideaid=244315e3-d8bb-f011-aa43-7c1e52a6c1f4

Adds logic to recalculate and set custom variant names after standard data fill-in, using a new event (OnAfterFillInProductVariantDataFromVariant).

Fixes AB#617325

@tVisionDeb tVisionDeb requested a review from a team as a code owner January 2, 2026 14:47
@github-actions github-actions bot added AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork labels Jan 2, 2026
@onbuyuka onbuyuka added the Linked Issue is linked to a Azure Boards work item label Jan 5, 2026
@onbuyuka onbuyuka changed the title Fixes #5867 [Shopify] Variant option extensibility Jan 5, 2026
@github-actions github-actions bot added this to the Version 28.0 milestone Jan 5, 2026
@onbuyuka onbuyuka enabled auto-merge (squash) January 5, 2026 10:59
@onbuyuka
Copy link
Contributor

onbuyuka commented Jan 6, 2026

@tVisionDeb build fails due to compilation errors:

  Compilation started for project 'Shopify Connector' containing '624' files at '11:43:49.466'.
  
  Error: AL0161 'OnAfterFillInProductVariantDataFromVariant(var Record "Shpfy Variant", Record Item, Record "Item Variant", Record "Item Unit of Measure", Record "Shpfy Shop")' is inaccessible due to its protection level
  Error: AL0118 The name 'ItemUnitofMeasure' does not exist in the current context.
  Error: AL0161 'OnAfterFillInProductVariantDataFromVariant(var Record "Shpfy Variant", Record Item, Record "Item Variant", Record "Item Unit of Measure", Record "Shpfy Shop")' is inaccessible due to its protection level

@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Jan 6, 2026
/// <param name="ItemUnitofMeasure">The source Item Unit of Measure record.</param>
/// <param name="Shop">The Shopify shop context.</param>
[IntegrationEvent(false, false)]
local procedure OnAfterFillInProductVariantDataFromVariant(var ShopifyVariant: Record "Shpfy Variant"; Item: Record Item; ItemVariant: Record "Item Variant"; ItemUnitofMeasure: Record "Item Unit of Measure"; Shop: Record "Shpfy Shop")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this procedure cannot be local, as it's called from a different codeunit. Maybe you meant "internal"?

Suggested change
local procedure OnAfterFillInProductVariantDataFromVariant(var ShopifyVariant: Record "Shpfy Variant"; Item: Record Item; ItemVariant: Record "Item Variant"; ItemUnitofMeasure: Record "Item Unit of Measure"; Shop: Record "Shpfy Shop")
internal procedure OnAfterFillInProductVariantDataFromVariant(var ShopifyVariant: Record "Shpfy Variant"; Item: Record Item; ItemVariant: Record "Item Variant"; ItemUnitofMeasure: Record "Item Unit of Measure"; Shop: Record "Shpfy Shop")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BC Idea]: OnAfterFillInProductVariantDataFromVariant event in Shopify connector

3 participants