Skip to content

Conversation

@edwardUL99
Copy link
Contributor

@edwardUL99 edwardUL99 commented Jan 22, 2026

Summary

The RequestDislikeFeedback method had ContextFiles and ContextProperties in a different order than the other methods, which could lead to bugs.

While on paper, this is a breaking change, it is an internal only API, and has very little usage. So, I believe that we can except it in this case, after speaking with quentin

Also, made the methods scope on prem to indicate non-public use

Work Item(s)

Fixes AB#615526

@edwardUL99 edwardUL99 requested a review from a team as a code owner January 22, 2026 13:29
@github-actions github-actions bot added this to the Version 28.0 milestone Jan 22, 2026
@github-actions
Copy link

github-actions bot commented Feb 8, 2026

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

@edwardUL99 edwardUL99 closed this Feb 9, 2026
@edwardUL99 edwardUL99 reopened this Feb 9, 2026
@edwardUL99 edwardUL99 merged commit 14a4533 into main Feb 10, 2026
107 of 136 checks passed
@edwardUL99 edwardUL99 deleted the private/eddylynch/change_param_order branch February 10, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants