Skip to content

[Subcontracting] SubcontractingMgmt codeunit violates Single Responsibility Principle #6455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AleksandricMarko merged 1 commit into from
Feb 5, 2026
Merged

[Subcontracting] SubcontractingMgmt codeunit violates Single Responsibility Principle #6455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...racting/App/src/Process/Codeunits/Extensions/Manufacturing/SubcReqWkshMakeOrd.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ codeunit 99001516 "Subc. Req. Wksh. Make Ord."

local procedure HandleSubcontractingAfterPurchOrderLineInsert(var PurchaseLine: Record "Purchase Line"; var NextLineNo: Integer; var RequisitionLine: Record "Requisition Line")
var
SubcontractingManagement: Codeunit "Subcontracting Management";
SubcPurchaseOrderCreator: Codeunit "Subc. Purchase Order Creator";
begin
SubcontractingManagement.InsertProdDescriptionOnAfterInsertPurchOrderLine(PurchaseLine, RequisitionLine);
SubcontractingManagement.TransferSubcontractingProdOrderComp(PurchaseLine, RequisitionLine, NextLineNo);
SubcPurchaseOrderCreator.InsertProdDescriptionOnAfterInsertPurchOrderLine(PurchaseLine, RequisitionLine);
SubcPurchaseOrderCreator.TransferSubcontractingProdOrderComp(PurchaseLine, RequisitionLine, NextLineNo);
end;
}
2 changes: 1 addition & 1 deletion ...pp/src/Process/Codeunits/Extensions/Manufacturing/SubcontractingManagementExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ codeunit 99001527 "Subcontracting Management Ext."
{
EventSubscriberInstance = Manual;

[EventSubscriber(ObjectType::Codeunit, Codeunit::"Subcontracting Management", OnBeforeHandleProdOrderRtngWorkCenterWithSubcontractor, '', false, false)]
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Subc. Purchase Order Creator", OnBeforeHandleProdOrderRtngWorkCenterWithSubcontractor, '', false, false)]
local procedure OnBeforeHandleProdOrderRtngWorkCenterWithSubcontractor(var SubContractorWorkCenterNo: Code[20])
var
SingleInstanceDictionary: Codeunit "Single Instance Dictionary";
Expand Down
555 changes: 555 additions & 0 deletions src/Apps/W1/Subcontracting/App/src/Process/Codeunits/SubcPurchaseOrderCreator.Codeunit.al
View file
Open in desktop

Large diffs are not rendered by default.

527 changes: 0 additions & 527 deletions src/Apps/W1/Subcontracting/App/src/Process/Codeunits/SubcontractingManagement.Codeunit.al
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions .../Subcontracting/App/src/Process/Pageextensions/Manufacturing/SubcProdOrderRtng.PageExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,14 @@ pageextension 99001503 "Subc. Prod. Order Rtng." extends "Prod. Order Routing"
var
ProdOrderRoutingLine: Record "Prod. Order Routing Line";
PurchaseLine: Record "Purchase Line";
SubcontractingManagement: Codeunit "Subcontracting Management";
SubcPurchaseOrderCreator: Codeunit "Subc. Purchase Order Creator";
NoOfCreatedPurchOrder: Integer;
NoPurchOrderCreatedMsg: Label 'No subcontracting order was created for the selected operations in production order %1. Please check whether the operation or operations have already been completed.', Comment = '%1=Production Order No.';
begin
CurrPage.SetSelectionFilter(ProdOrderRoutingLine);
ProdOrderRoutingLine.FindSet();
repeat
NoOfCreatedPurchOrder += SubcontractingManagement.CreateSubcontractingPurchaseOrderFromRoutingLine(ProdOrderRoutingLine);
NoOfCreatedPurchOrder += SubcPurchaseOrderCreator.CreateSubcontractingPurchaseOrderFromRoutingLine(ProdOrderRoutingLine);
until ProdOrderRoutingLine.Next() = 0;

if NoOfCreatedPurchOrder = 0 then begin
Expand All @@ -74,10 +74,10 @@ pageextension 99001503 "Subc. Prod. Order Rtng." extends "Prod. Order Routing"
Message(NoPurchOrderCreatedMsg, ProdOrderRoutingLine."Prod. Order No.")
end else begin
if NoOfCreatedPurchOrder = 1 then begin
SubcontractingManagement.ClearOperationNoForCreatedPurchaseOrder();
SubcontractingManagement.SetOperationNoForCreatedPurchaseOrder(Rec."Operation No.");
SubcPurchaseOrderCreator.ClearOperationNoForCreatedPurchaseOrder();
SubcPurchaseOrderCreator.SetOperationNoForCreatedPurchaseOrder(Rec."Operation No.");
end;
SubcontractingManagement.ShowCreatedPurchaseOrder(Rec."Prod. Order No.", NoOfCreatedPurchOrder);
SubcPurchaseOrderCreator.ShowCreatedPurchaseOrder(Rec."Prod. Order No.", NoOfCreatedPurchOrder);
end;
end;
}
Expand Down
4 changes: 2 additions & 2 deletions ...ing/App/src/Process/Prod Order Creation Wizard/Codeunits/SubcCreateProdOrdOpt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ codeunit 99001556 "Subc. Create Prod. Ord. Opt."
local procedure HandleSubcontractingAfterUpdate(var PurchaseLine: Record "Purchase Line")
var
RequisitionLine: Record "Requisition Line";
SubcontractingManagement: Codeunit "Subcontracting Management";
SubcPurchaseOrderCreator: Codeunit "Subc. Purchase Order Creator";
SubcontractingManagementExt: Codeunit "Subcontracting Management Ext.";
NextLineNo: Integer;
begin
Expand All @@ -620,7 +620,7 @@ codeunit 99001556 "Subc. Create Prod. Ord. Opt."

NextLineNo := PurchaseLine."Line No." + 10000;
BindSubscription(SubcontractingManagementExt);
SubcontractingManagement.TransferSubcontractingProdOrderComp(PurchaseLine, RequisitionLine, NextLineNo);
SubcPurchaseOrderCreator.TransferSubcontractingProdOrderComp(PurchaseLine, RequisitionLine, NextLineNo);
UnbindSubscription(SubcontractingManagementExt);
end;

Expand Down
2 changes: 1 addition & 1 deletion src/Apps/W1/Subcontracting/Test/src/Codeunits/Libraries/SubcTestManSubscription.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ codeunit 139985 "Subc. Test Man. Subscription"
{
EventSubscriberInstance = Manual;

[EventSubscriber(ObjectType::Codeunit, Codeunit::"Subcontracting Management", OnBeforeShowCreatedPurchaseOrder, '', false, false)]
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Subc. Purchase Order Creator", OnBeforeShowCreatedPurchaseOrder, '', false, false)]
local procedure OnBeforeShowCreatedPurchaseOrder(var IsHandled: Boolean)
begin
IsHandled := true;
Expand Down
Loading