Skip to content

[Agent] Remove NotBlank property from SelectAgentPermissions#6542

Merged
qutreson merged 1 commit intomainfrom
bugs/tfs/619697
Feb 9, 2026
Merged

[Agent] Remove NotBlank property from SelectAgentPermissions#6542
qutreson merged 1 commit intomainfrom
bugs/tfs/619697

Conversation

@qutreson
Copy link
Contributor

@qutreson qutreson commented Feb 9, 2026

Summary

Removing the NotBlank property from the Role ID field since it prevented clicking on Assign My Permissions action on an empty list of permissions (sunshine scenario when doing a first time setup). By using validation trigger code, we prevent users from entering empty values, yet we unblock the action.

Work Item(s)

Fixes AB#619697

@qutreson qutreson requested a review from a team as a code owner February 9, 2026 15:19
@github-actions github-actions bot added this to the Version 28.0 milestone Feb 9, 2026
@qutreson qutreson merged commit 3297f27 into main Feb 9, 2026
52 checks passed
@qutreson qutreson deleted the bugs/tfs/619697 branch February 9, 2026 18:34
qutreson added a commit that referenced this pull request Feb 10, 2026
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
Removing the NotBlank property from the Role ID field since it prevented
clicking on Assign My Permissions action on an empty list of permissions
(sunshine scenario when doing a first time setup). By using validation
trigger code, we prevent users from entering empty values, yet we
unblock the action.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#619697](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/619697)
qutreson added a commit that referenced this pull request Feb 10, 2026
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
Backports of #6494 and #6542 

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#619697](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/619697)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants