Skip to content

Uptaking the refactored Power BI synch engine for the OOB apps#6763

Merged
mynjj merged 23 commits intomainfrom
features/pbiautdepl2
Apr 13, 2026
Merged

Uptaking the refactored Power BI synch engine for the OOB apps#6763
mynjj merged 23 commits intomainfrom
features/pbiautdepl2

Conversation

@mynjj
Copy link
Copy Markdown
Contributor

@mynjj mynjj commented Feb 19, 2026

Summary

  • Introduce the PBI Report Setup enum and interface to represent Power BI report app configurations, replacing raw field IDs with strongly-typed enum values
  • Refactor all embedded report pages (~120) to use the new OpenPowerBIEmbeddedReportPageValidation procedure, which consolidates EnsureUserAcceptedPowerBITerms + GetReportIdAndEnsureSetup + deployment-in-progress prompts into a single call
  • Adds a new wizard experience for deploying reports when selecting an unconfigured embedded report page (for evaluation companies)
  • Add FindReportSetup to resolve a Deployable Report type back to its PBI Report Setup interface, eliminating repeated ordinal iteration in subscribers and the deployments page extension
  • Fix a pre-existing bug where the ABC Analysis page (Inventory) was incorrectly referencing the Sales report ID

Work Item(s)

Fixes AB#600448

@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Feb 19, 2026
@mynjj mynjj requested a review from a team March 16, 2026 12:49
@mynjj mynjj marked this pull request as ready for review April 1, 2026 14:28
@mynjj mynjj requested review from a team as code owners April 1, 2026 14:28
@github-actions github-actions Bot modified the milestone: Version 29.0 Apr 1, 2026
@mynjj mynjj enabled auto-merge (squash) April 8, 2026 14:33
Joshua Martínez Pineda and others added 4 commits April 10, 2026 10:20
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AL Documentation Audit

Documentation gaps were detected in the following apps:

  • Power-BI-Report-embeddings-for-Dynamics-365-Business-Central: 0% documentation coverage
  • Subscription-Billing: 0% documentation coverage

To generate documentation, run /al-docs init or /al-docs update using GitHub Copilot CLI or Claude Code.
This review is for awareness to help keep documentation in sync with code changes. It is okay to dismiss this request.

Jose-agg
Jose-agg previously approved these changes Apr 10, 2026
…#7642)

The `ReportSetupChoice` PageField in `PowerBIAssistedSetup.Page.al`
violated AL rule AA0219, which requires all PageField `ToolTip`
properties to begin with `'Specifies'`.

## Change

- **`PowerBIAssistedSetup.Page.al`**: Updated `ToolTip` on
`ReportSetupChoice` field

```al
// Before
ToolTip = 'Choose whether to manually configure report settings or deploy pre-built reports.';

// After
ToolTip = 'Specifies whether to manually configure report settings or deploy pre-built reports.';
```

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mynjj <61959453+mynjj@users.noreply.github.com>
…eport.EnumExt.al (#7643)

AA0215 flags `PBISubBillingDeployableReport.EnumExt.al` as having an
invalid filename — the object name `"PBI Sub. Billing Depl. Report"`
requires the file to be named `PBISubBillingDeplReport.EnumExt.al`.

## Changes
- **Renamed** `src/Apps/W1/Subscription Billing/App/Power
BI/PBISubBillingDeployableReport.EnumExt.al` →
`PBISubBillingDeplReport.EnumExt.al` — filename-only change, no content
modifications.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mynjj <61959453+mynjj@users.noreply.github.com>
@mynjj
Copy link
Copy Markdown
Contributor Author

mynjj commented Apr 11, 2026

@copilot

2026-04-11T08:39:12.0102512Z Compilation started for project 'Subscription Billing Demo Data' containing '26' files at '08:38:52.790'.
2026-04-11T08:39:12.0112705Z
2026-04-11T08:39:12.0436899Z ##[error]AL0264 An application object of type 'EnumExtension' with ID '8101' is already declared by the extension 'Subscription Billing by Microsoft (29.0.2147483647.72505)'
2026-04-11T08:39:12.0444480Z

in this pr a new enumextension was introduced in the Subscription Billing extension (not on demodata). renumber it to a non occupied id (and still within the range in app.json)

…void ID conflict with Demo Data

Agent-Logs-Url: https://github.com/microsoft/BCApps/sessions/1dcd817f-10aa-45cb-8d87-85ac1da218a8

Co-authored-by: mynjj <61959453+mynjj@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 11, 2026

@copilot

2026-04-11T08:39:12.0102512Z Compilation started for project 'Subscription Billing Demo Data' containing '26' files at '08:38:52.790'.
...

Fixed in b516679. Renumbered the PBI Sub. Billing Depl. Report enumextension from 8101 to 81038101 was already taken by the Demo Data app's Sub. Billing Contoso Demo Data enumextension, and 8103 is free within the Main App's declared range (8000–8113).

Joshua Martínez Pineda and others added 2 commits April 13, 2026 09:55
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@mynjj mynjj merged commit 80a0efb into main Apr 13, 2026
38 checks passed
@mynjj mynjj deleted the features/pbiautdepl2 branch April 13, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants