Skip to content

[Shopify] Handle deleted fulfillment service location in Shopify #6847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onbuyuka merged 1 commit into from
Feb 26, 2026
+11 −2
Merged

[Shopify] Handle deleted fulfillment service location in Shopify #6847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/Apps/W1/Shopify/App/src/Inventory/Codeunits/ShpfySyncShopLocations.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,11 @@ codeunit 30198 "Shpfy Sync Shop Locations"
if not ShopLocation.FindFirst() then
exit;

if ShopLocation."Fulfillment Service Id" = 0 then
if ShopLocation."Fulfillment Service Id" = 0 then begin
GetFulfillmentService(ShopLocation);
if ShopLocation."Fulfillment Service Id" = 0 then
exit;
end;

if ShopLocation."Fulfillment Srv. Callback Url" = GetFulfillmentServiceCallbackUrl() then
exit;
Expand All @@ -148,13 +151,19 @@ codeunit 30198 "Shpfy Sync Shop Locations"
GraphQLType: Enum "Shpfy GraphQL Type";
Parameters: Dictionary of [Text, Text];
JResponse: JsonToken;
JLocation: JsonObject;
JFulfillmentService: JsonObject;
begin
GraphQLType := "Shpfy GraphQL Type"::GetLocation;
Parameters.Add('Id', Format(ShopLocation.Id));
JResponse := CommunicationMgt.ExecuteGraphQL(GraphQLType, Parameters);

if not JsonHelper.GetJsonObject(JResponse, JFulfillmentService, 'data.location.fulfillmentService') then
if not JsonHelper.GetJsonObject(JResponse, JLocation, 'data.location') then begin
ShopLocation.Delete(true);
exit;
end;

if not JsonHelper.GetJsonObject(JLocation.AsToken(), JFulfillmentService, 'fulfillmentService') then
exit;

ShopLocation."Fulfillment Service Id" := CommunicationMgt.GetIdOfGId(JsonHelper.GetValueAsText(JFulfillmentService, 'id'));
Expand Down
Loading