[Shopify] Check fulfillment service exists before querying assigned fulfillment orders#6904
Merged
[Shopify] Check fulfillment service exists before querying assigned fulfillment orders#6904
Conversation
onbuyuka
changed the title
onbuyuka
changed the title
darjoo
approved these changes
Mar 2, 2026
mynjj
approved these changes
Mar 2, 2026
onbuyuka
added a commit
that referenced
this pull request
Mar 3, 2026
…ulfillment orders (#6904) When syncing shipments to Shopify, the `assignedFulfillmentOrders` GraphQL call fails with "The api_client is not associated with any fulfillment service" if the fulfillment service was disassociated on Shopify's side (e.g., app reinstall, store migration). ## Changes - **New GraphQL query** (`HasFulfillmentService`): Queries Shopify locations by name to verify the fulfillment service location exists before calling `assignedFulfillmentOrders`. - **`GetAssignedFulfillmentOrders`**: After the existing `Fulfillment Service Activated` flag check, queries Shopify to confirm the service actually exists. If not, resets the flag to `false` and exits gracefully. - **`ShpfySyncShipmToShopify`**: Tracks queried shop codes separately to avoid redundant API calls when a shop has no assigned fulfillment orders. Fixes [AB#623365](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/623365)
onbuyuka
added a commit
that referenced
this pull request
Mar 4, 2026
## Summary - Check that a fulfillment service exists before querying assigned fulfillment orders - Handle deleted fulfillment service locations in Shopify sync Fixes [AB#623993](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/623993) Cherry-picked from main: - 3c83280 [Shopify] Check fulfillment service exists before querying assigned fulfillment orders (#6904) - 1819203 [Shopify] Handle deleted fulfillment service location in Shopify (#6847) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When syncing shipments to Shopify, the
assignedFulfillmentOrdersGraphQL call fails with "The api_client is not associated with any fulfillment service" if the fulfillment service was disassociated on Shopify's side (e.g., app reinstall, store migration).Changes
HasFulfillmentService): Queries Shopify locations by name to verify the fulfillment service location exists before callingassignedFulfillmentOrders.GetAssignedFulfillmentOrders: After the existingFulfillment Service Activatedflag check, queries Shopify to confirm the service actually exists. If not, resets the flag tofalseand exits gracefully.ShpfySyncShipmToShopify: Tracks queried shop codes separately to avoid redundant API calls when a shop has no assigned fulfillment orders.Fixes AB#623365