E-Document PO matching improvements#7021
Merged
Merged
Conversation
added 3 commits
March 6, 2026 12:25
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors E-Document purchase order matching warnings to replace the coarse-grained QuantityMismatch and NotYetReceived warning types with more specific, granular warning types: ExceedsInvoiceableQty, ExceedsRemainingToInvoice, and OverReceipt. It also improves the UI presentation by adding severity-based styling, a drill-down detail view, and a warning message field. Additionally, it adds a missing UoM validation check during invoice finalization.
Changes:
- Replaced
QuantityMismatch/NotYetReceivedwarnings with three new granular warning types (ExceedsInvoiceableQty,ExceedsRemainingToInvoice,OverReceipt) with computed warning messages stored in a new"Warning Message"field on the table - Refactored the draft subform page to display warnings with severity-based styling (Unfavorable/Ambiguous/Subordinate) and added a drill-down to show detailed warning messages
- Added a
MissingInformationForMatchcheck during invoice finalization to block creation when UoM information is missing
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
EDocPOMatchWarning.Enum.al |
Added three new enum values: ExceedsInvoiceableQty, ExceedsRemainingToInvoice, OverReceipt |
EDocPOMatchWarning.Table.al |
Added "Warning Message" Text[250] field to store computed warning details |
EDocPOMatching.Codeunit.al |
Replaced old warning logic with new granular quantity checks (I vs R, I vs J) and updated finalization/validation references |
EDocPurchaseDraftSubform.Page.al |
Extracted UpdateMatchWarnings and ShowMatchWarningDetails procedures; added severity-based styling and drill-down |
EDocCreatePurchaseInvoice.Codeunit.al |
Updated finalization to check ExceedsInvoiceableQty and added MissingInformationForMatch blocking check |
EDocPOMatchingUnitTests.Codeunit.al |
Expanded tests from 2 to 5 quantity warning scenarios, updated all references to new warning types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Groenbech96
previously approved these changes
Mar 7, 2026
AleksanderGladkov
approved these changes
Mar 10, 2026
djukicmilica
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#621954