Skip to content

[Quality Management] [28.0] Standardize permisssion sets naming #7314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JakovljevicDusan merged 2 commits into from
Mar 24, 2026
Merged

[Quality Management] [28.0] Standardize permisssion sets naming #7314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee91e3f
[Quality Management] Standardize 'QltyMngmnt' to 'QltyMgmt' across pe…
JakovljevicDusan Mar 23, 2026
8848cbe
Include permissionsetextension
JakovljevicDusan Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Apps/W1/Quality Management/Test Library/src/QltyInspectionUtility.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ codeunit 139940 "Qlty. Inspection Utility"
LibraryUtility: Codeunit "Library - Utility";
NoSeriesCodeunit: Codeunit "No. Series";
DefaultResult2PassCodeLbl: Label 'PASS', Locked = true;
AdminSupervisorRoleIDTok: Label 'QltyMngmnt - Admin', Locked = true;
AdminSupervisorRoleIDTok: Label 'QltyMgmt - Admin', Locked = true;

internal procedure EnsureSetupExists()
var
Expand Down
2 changes: 1 addition & 1 deletion src/Apps/W1/Quality Management/app/src/AccessControl/QltyPermissionMgmt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ codeunit 20406 "Qlty. Permission Mgmt."
ActionChangeItemTrackingLbl: Label 'change item tracking';
ActionChangeSourceQuantityLbl: Label 'change source quantity';
ActionEditLineCommentLbl: Label 'edit line note/comment';
AdminSupervisorRoleIDTxt: Label 'QltyMngmnt - Admin', Locked = true;
AdminSupervisorRoleIDTxt: Label 'QltyMgmt - Admin', Locked = true;
UserDoesNotHavePermissionToErr: Label 'The user [%1] does not have permission to [%2].', Comment = '%1=User id, %2=permission being attempted';

/// <summary>
Expand Down
8 changes: 5 additions & 3 deletions ...365BasicIsvQltyMngmnt.PermissionSetExt.al → ...AdministratorQltyMgmt.PermissionSetExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ namespace Microsoft.QualityManagement.Permissions;

using System.Security.AccessControl;

permissionsetextension 20400 "D365 BASIC ISV - QltyMngmnt" extends "D365 BASIC ISV"
#pragma warning disable AS0090
permissionsetextension 20402 "Administrator - QltyMgmt" extends "Administrator"
{
IncludedPermissionSets = "QltyMngmnt - Admin";
}
IncludedPermissionSets = "QltyMgmt - Admin";
}
#pragma warning restore AS0090
8 changes: 5 additions & 3 deletions ...sFullAccessQltyMngmnt.PermissionSetExt.al → .../D365BasicIsvQltyMgmt.PermissionSetExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ namespace Microsoft.QualityManagement.Permissions;

using System.Security.AccessControl;

permissionsetextension 20401 "D365 BUS FULL ACCESS - QltyMngmnt" extends "D365 BUS FULL ACCESS"
#pragma warning disable AS0090
permissionsetextension 20400 "D365 BASIC ISV - QltyMgmt" extends "D365 BASIC ISV"
{
IncludedPermissionSets = "QltyMngmnt - Admin";
}
IncludedPermissionSets = "QltyMgmt - Admin";
}
#pragma warning restore AS0090
8 changes: 5 additions & 3 deletions ...ns/D365ReadQltyMngmnt.PermissionSetExt.al → ...BusFullAccessQltyMgmt.PermissionSetExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ namespace Microsoft.QualityManagement.Permissions;

using System.Security.AccessControl;

permissionsetextension 20403 "D365 READ - QltyMngmnt" extends "D365 READ"
#pragma warning disable AS0090
permissionsetextension 20401 "D365 BUS FULL ACCESS - QltyMgmt" extends "D365 BUS FULL ACCESS"
{
IncludedPermissionSets = "QltyMngmnt - Read";
}
IncludedPermissionSets = "QltyMgmt - Admin";
}
#pragma warning restore AS0090
8 changes: 5 additions & 3 deletions ...ministratorQltyMngmnt.PermissionSetExt.al → ...ions/D365ReadQltyMgmt.PermissionSetExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ namespace Microsoft.QualityManagement.Permissions;

using System.Security.AccessControl;

permissionsetextension 20402 "Administrator - QltyMngmnt" extends "Administrator"
#pragma warning disable AS0090
permissionsetextension 20403 "D365 READ - QltyMgmt" extends "D365 READ"
{
IncludedPermissionSets = "QltyMngmnt - Admin";
}
IncludedPermissionSets = "QltyMgmt - Read";
}
#pragma warning restore AS0090
6 changes: 3 additions & 3 deletions ...missions/QltyMngmntAdmin.PermissionSet.al → ...ermissions/QltyMgmtAdmin.PermissionSet.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ using Microsoft.QualityManagement.Workflow;
/// </summary>
#pragma warning disable AS0125
#pragma warning disable AS0090
permissionset 20405 "QltyMngmnt - Admin"
permissionset 20405 "QltyMgmt - Admin"
{
Caption = 'Quality Management - Administrator';
Caption = 'Quality Admin & Supervisor';
Access = Public;
Assignable = true;

IncludedPermissionSets = "QltyMngmnt - Objects";
IncludedPermissionSets = "QltyMgmt - Objects";

Permissions =
tabledata "Qlty. Management Setup" = RIMD,
Expand Down
11 changes: 7 additions & 4 deletions ...ions/QltyMngmntInspector.PermissionSet.al → ...ssions/QltyMgmtInspector.PermissionSet.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,15 @@ using Microsoft.QualityManagement.Workflow;
/// <summary>
/// Used for working with Quality Inspections.
/// </summary>
permissionset 20404 QltyMngmntInspector
#pragma warning disable AS0125
#pragma warning disable AS0090
permissionset 20404 "QltyMgmt - Inspector"
{
Caption = 'Quality Management - Quality Inspector';
Caption = 'Quality Inspector';
Access = Public;
Assignable = true;

IncludedPermissionSets = "QltyMngmnt - Objects";
IncludedPermissionSets = "QltyMgmt - Objects";

Permissions =
tabledata "Qlty. Workflow Config. Value" = Rim,
Expand All @@ -41,4 +43,5 @@ permissionset 20404 QltyMngmntInspector
tabledata "Qlty. Inspection Header" = RIMd,
tabledata "Qlty. Test" = R;
}

#pragma warning restore AS0090
#pragma warning restore AS0125
8 changes: 6 additions & 2 deletions ...ssions/QltyMngmntObjects.PermissionSet.al → ...missions/QltyMgmtObjects.PermissionSet.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,13 @@ using Microsoft.QualityManagement.Setup.SetupGuide;
using Microsoft.QualityManagement.Utilities;
using Microsoft.QualityManagement.Workflow;

permissionset 20406 "QltyMngmnt - Objects"
#pragma warning disable AS0125
#pragma warning disable AS0090
permissionset 20406 "QltyMgmt - Objects"
{
Caption = 'Quality Management - Objects';
Access = Internal;
Assignable = true;
Assignable = false;

Permissions =
// Codeunits
Expand Down Expand Up @@ -165,3 +167,5 @@ permissionset 20406 "QltyMngmnt - Objects"
table "Qlty. Inspection Header" = X,
table "Qlty. Test" = X;
}
#pragma warning restore AS0090
#pragma warning restore AS0125
10 changes: 7 additions & 3 deletions ...rmissions/QltyMngmntRead.PermissionSet.al → ...Permissions/QltyMgmtRead.PermissionSet.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,15 @@ using Microsoft.QualityManagement.Workflow;
/// <summary>
/// Used for full read-only access to Quality Management.
/// </summary>
permissionset 20401 "QltyMngmnt - Read"
#pragma warning disable AS0125
#pragma warning disable AS0090
permissionset 20401 "QltyMgmt - Read"
{
Caption = 'Quality Management - Read access';
Caption = 'Quality Auditor';
Access = Public;
Assignable = true;

IncludedPermissionSets = "QltyMngmnt - Objects";
IncludedPermissionSets = "QltyMgmt - Objects";

Permissions =
tabledata "Qlty. Management Setup" = R,
Expand All @@ -43,3 +45,5 @@ permissionset 20401 "QltyMngmnt - Read"
tabledata "Qlty. Inspection Header" = R,
tabledata "Qlty. Inspection Line" = R;
}
#pragma warning restore AS0090
#pragma warning restore AS0125
2 changes: 1 addition & 1 deletion src/Apps/W1/Quality Management/test/src/QltyTestsPermissionMgmt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ codeunit 139957 "Qlty. Tests - Permission Mgmt."
QltyInspectionUtility: Codeunit "Qlty. Inspection Utility";
LibraryAssert: Codeunit "Library Assert";
UserDoesNotHavePermissionToErr: Label 'The user [%1] does not have permission to [%2].', Comment = '%1=User id, %2=permission being attempted';
AdminSupervisorRoleIDTok: Label 'QltyMngmnt - Admin', Locked = true;
AdminSupervisorRoleIDTok: Label 'QltyMgmt - Admin', Locked = true;

[Test]
procedure VerifyCanCreateManualInspection_ShouldError()
Expand Down
Loading