Fix eDocument PEPPOL BIS 3.0 import errors for text-only document references and hierarchical line IDs#7362
Merged
Groenbech96 merged 4 commits intomainfrom Mar 25, 2026
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
AL Documentation Audit
Documentation gaps were detected in the following apps:
- E-Document-Core-Tests: 0% documentation coverage
- E-Document-Core: 4% documentation coverage
To generate documentation, run /al-docs init or /al-docs update using GitHub Copilot CLI or Claude Code.
This review is for awareness to help keep documentation in sync with code changes. It is okay to dismiss this request.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mynjj
approved these changes
Mar 25, 2026
ventselartur
approved these changes
Mar 25, 2026
Groenbech96
added a commit
that referenced
this pull request
Mar 25, 2026
…erences and hierarchical line IDs (#7362) ## Summary - Fix "Please choose a file to attach" error when importing PEPPOL invoices/credit memos with `AdditionalDocumentReference` elements that have no `<cac:Attachment>` child (text-only references). Added `"File Name" <> ''` guard to all 4 attachment insert locations. - Fix "The value '1.1' can't be evaluated into type Integer" error when importing documents with hierarchical line numbering (e.g., 1.1, 1.2). Replaced direct `Evaluate` of XML line ID with auto-incrementing counter (10000, 20000, ...) passed as `var` parameter from caller to parser. - Added test XML fixtures and automated tests in `EDocumentStructuredTests`. [AB#626739](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/626739) --------- Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Groenbech96
added a commit
that referenced
this pull request
Mar 25, 2026
…erences and hierarchical line IDs (#7362) ## Summary - Fix "Please choose a file to attach" error when importing PEPPOL invoices/credit memos with `AdditionalDocumentReference` elements that have no `<cac:Attachment>` child (text-only references). Added `"File Name" <> ''` guard to all 4 attachment insert locations. - Fix "The value '1.1' can't be evaluated into type Integer" error when importing documents with hierarchical line numbering (e.g., 1.1, 1.2). Replaced direct `Evaluate` of XML line ID with auto-incrementing counter (10000, 20000, ...) passed as `var` parameter from caller to parser. - Added test XML fixtures and automated tests in `EDocumentStructuredTests`. [AB#626739](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/626739) --------- Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AdditionalDocumentReferenceelements that have no<cac:Attachment>child (text-only references). Added"File Name" <> ''guard to all 4 attachment insert locations.Evaluateof XML line ID with auto-incrementing counter (10000, 20000, ...) passed asvarparameter from caller to parser.EDocumentStructuredTests.AB#626739