Fix GDAP plan assignment for former guest users#7490
Closed
darjoo wants to merge 1 commit into
Closed
Conversation
…ormer guest users ADO #612420: [GDAP] GDAP user who were previously guest users in the environment, don't get the GDAP license and updated Root Cause: - In AssignPlanToUserWithDelegatedRole, two early-exit conditions (SkipUpdateUserAccess and HasPlans) prevented user access from being updated when a returning user's plan changed from guest to GDAP. Both were redundant because the IsPlanAssignedToUser check already prevents re-processing when the same plan is already assigned. Changes: - Removed `if SkipUpdateUserAccess then exit` check that blocked access updates for returning users whose plan genuinely changed - Removed `if HasPlans then exit` check that was also redundant - Removed unused `HasPlans` local variable Test Coverage: - Added GDAPUserWithPreviousGuestPlanGetsAccessUpdated test verifying that a delegated admin user with a previous guest plan gets the GDAP plan assigned and access updated even when SkipUpdateUserAccess = true - Number of fix iterations: 2 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AssignPlanToUserWithDelegatedRole(AzureADPlanImpl.Codeunit.al) that blocked plan re-assignment when a user's plan changed from guest to GDAPGDAPUserWithPreviousGuestPlanGetsAccessUpdatedverifying the fixRoot Cause
In
AssignPlanToUserWithDelegatedRole, two early-exit checks (SkipUpdateUserAccessandHasPlans) prevented user access from being updated when a returning user's plan changed from guest to GDAP. Both were redundant becauseIsPlanAssignedToUseralready prevents re-processing when the same plan is already assigned.Test plan
GDAPUserWithPreviousGuestPlanGetsAccessUpdated— verifies delegated admin with previous guest plan gets GDAP plan assigned🤖 Generated with Claude Code
Fixes AB#612420