Skip to content

[Shopify] Fix duplicate Sync Prices on B2B Catalogs and GraphQL quote escaping#7585

Merged
onbuyuka merged 1 commit intomainfrom
bugs/630273-b2b-catalog-sync-prices-conflict
Apr 13, 2026
Merged

[Shopify] Fix duplicate Sync Prices on B2B Catalogs and GraphQL quote escaping#7585
onbuyuka merged 1 commit intomainfrom
bugs/630273-b2b-catalog-sync-prices-conflict

Conversation

@onbuyuka
Copy link
Copy Markdown
Contributor

@onbuyuka onbuyuka commented Apr 8, 2026

Summary

  • Add confirmation dialog on the Sync Prices field validation in B2B Catalogs. When enabling Sync Prices on a catalog that already has it enabled for another company (same catalog ID, different company), the user is prompted to disable it on the other line(s). This prevents conflicting pricing configurations that are silently ignored during sync.
  • Fix doubled single quotes (''') in 3 GraphQL resource files (GetCatalogs, GetNextCatalogs, HasFulfillmentService) introduced during the PR [Shopify] Replace GraphQL query codeunits with resource files #7198 migration from AL codeunits to .graphql resource files. In AL string literals '' is an escape for ', but in plain-text resource files it's literal, causing Shopify to reject the query parameters.

Test plan

  • SyncPricesConfirmDisablesOtherLine — user confirms, other catalog line gets Sync Prices disabled
  • SyncPricesCancelKeepsBothUnchanged — user cancels, no changes
  • SyncPricesNoConfirmWhenNoDuplicate — no duplicate, no dialog, field enables normally

Fixes AB#630273

🤖 Generated with Claude Code

… escaping

Add confirmation dialog when enabling Sync Prices on a catalog that already
has it enabled for another company, preventing conflicting pricing configs.
Fix doubled single quotes in GraphQL resource files from PR #7198 migration.

Fixes AB#630273

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@onbuyuka onbuyuka requested a review from a team as a code owner April 8, 2026 11:32
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Apr 8, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Apr 8, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AL Documentation Audit

Documentation gaps were detected in the following apps:

  • Shopify-Connector: 93% documentation coverage

To generate documentation, run /al-docs init or /al-docs update using GitHub Copilot CLI or Claude Code.
This review is for awareness to help keep documentation in sync with code changes. It is okay to dismiss this request.

@onbuyuka onbuyuka enabled auto-merge (squash) April 8, 2026 14:12
@github-actions
Copy link
Copy Markdown

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

@onbuyuka onbuyuka closed this Apr 13, 2026
auto-merge was automatically disabled April 13, 2026 08:11

Pull request was closed

@onbuyuka onbuyuka reopened this Apr 13, 2026
@onbuyuka onbuyuka enabled auto-merge (squash) April 13, 2026 08:12
@onbuyuka onbuyuka merged commit 02951bd into main Apr 13, 2026
58 checks passed
@onbuyuka onbuyuka deleted the bugs/630273-b2b-catalog-sync-prices-conflict branch April 13, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants