Skip to content

Deliverable 629871: [master] [UK] Payment Practices updates#7624

Merged
AleksanderGladkov merged 22 commits into
mainfrom
features/629871-master-Payment-Practices-W1-GB-Simple
May 18, 2026
Merged

Deliverable 629871: [master] [UK] Payment Practices updates#7624
AleksanderGladkov merged 22 commits into
mainfrom
features/629871-master-Payment-Practices-W1-GB-Simple

Conversation

@AleksanderGladkov
Copy link
Copy Markdown
Contributor

@AleksanderGladkov AleksanderGladkov commented Apr 9, 2026

What was done

  • Added a new Reporting Scheme dimension (Standard / Dispute & Retention / Small Business) so the app can support country-specific payment practice rules without affecting existing W1/FR users.
  • Implemented the UK (Dispute & Retention) scheme: dispute tracking, supply chain finance payment dates, and "% overdue due to dispute" reporting.
  • Implemented the AU/NZ (Small Business) scheme: filters reporting to small-business suppliers and adds invoice count / value per period.
  • Auto-detects the right scheme from the environment country on new reports, with an event for partners to override.
  • Upgrade logic backfills the scheme on existing headers, so nothing breaks for current users.
  • Surfaced the new fields and scheme selector on the relevant Payment Practice pages.
  • Extracted shared test helpers into a new Test Library app and expanded unit tests across all three schemes.

Fixes AB#629871

Fixes AB#626294

@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Apr 9, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Apr 9, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AL Documentation Audit

Documentation gaps were detected in the following apps:

  • Payment-Practices-Test-Library: 0% documentation coverage
  • Payment-Practices-Tests: 0% documentation coverage
  • Payment-Practices: 10% documentation coverage

To generate documentation, run /al-docs init or /al-docs update using GitHub Copilot CLI or Claude Code.
This review is for awareness to help keep documentation in sync with code changes. It is okay to dismiss this request.

@AleksanderGladkov AleksanderGladkov force-pushed the features/629871-master-Payment-Practices-W1-GB-Simple branch from 636e30c to fc0689b Compare April 27, 2026 10:07
@AleksanderGladkov AleksanderGladkov force-pushed the features/629871-master-Payment-Practices-W1-GB-Simple branch from fc0689b to f12e66b Compare April 27, 2026 12:58
Aleksandr Gladkov added 5 commits April 27, 2026 15:01
…res/629871-master-Payment-Practices-W1-GB-Simple
…res/629871-master-Payment-Practices-W1-GB-Simple
…res/629871-master-Payment-Practices-W1-GB-Simple
@AleksanderGladkov AleksanderGladkov marked this pull request as ready for review April 30, 2026 08:43
@AleksanderGladkov AleksanderGladkov requested review from a team as code owners April 30, 2026 08:43
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

Comment thread src/Apps/W1/PaymentPractices/App/src/Core/PaymentPracticeMath.Codeunit.al Outdated
Comment thread src/Apps/W1/PaymentPractices/App/src/Core/PaymentPracticeMath.Codeunit.al Outdated
Comment thread src/Apps/W1/PaymentPractices/App/src/Pages/PaymPracVendLedgEntr.PageExt.al Outdated
Comment thread src/Apps/W1/PaymentPractices/App/src/Tables/PaymentPracticeHeader.Table.al Outdated
Comment thread src/Apps/W1/PaymentPractices/App/src/Tables/PaymentPracticeHeader.Table.al Outdated
Comment thread src/Apps/W1/PaymentPractices/App/src/Tables/PaymentPracticeHeader.Table.al Outdated
Comment thread src/Apps/W1/PaymentPractices/Test/src/PaymentPracticesUT.Codeunit.al Outdated
Aleksandr Gladkov added 2 commits May 8, 2026 14:26
Comment thread src/Apps/W1/PaymentPractices/App/src/Core/PaymentPeriodMgt.Codeunit.al Outdated
Comment thread src/Apps/W1/PaymentPractices/App/src/Core/PaymentPeriodMgt.Codeunit.al Outdated
Comment thread src/Apps/W1/PaymentPractices/App/src/Core/PaymentPractices.Codeunit.al Outdated
Comment thread src/Apps/W1/PaymentPractices/App/src/Core/PaymentPracticeMath.Codeunit.al Outdated
Comment thread src/Apps/W1/PaymentPractices/App/src/Core/PaymentPracticeMath.Codeunit.al Outdated
Comment thread src/Apps/W1/PaymentPractices/App/src/Core/PaymentPracticeMath.Codeunit.al Outdated
Comment thread src/Apps/W1/PaymentPractices/App/src/Core/UpgradePaymentPractices.Codeunit.al Outdated
Comment thread src/Apps/W1/PaymentPractices/Test Library/src/PaymentPracticesLibrary.Codeunit.al Outdated
Copy link
Copy Markdown
Contributor

@ventselartur ventselartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, review my comments

…res/629871-master-Payment-Practices-W1-GB-Simple
Comment thread src/Apps/W1/PaymentPractices/App/src/Core/PaymentPracticeBuilders.Codeunit.al Outdated
@microsoft microsoft deleted a comment from github-actions Bot May 15, 2026
@microsoft microsoft deleted a comment from github-actions Bot May 15, 2026
@microsoft microsoft deleted a comment from github-actions Bot May 15, 2026
Comment thread src/Apps/W1/PaymentPractices/App/src/Core/PaymentPracticeMath.Codeunit.al Outdated
Comment thread src/Apps/W1/PaymentPractices/App/src/Core/PaymentPracticeMath.Codeunit.al Outdated
@AleksanderGladkov AleksanderGladkov merged commit 039313d into main May 18, 2026
66 of 68 checks passed
@AleksanderGladkov AleksanderGladkov deleted the features/629871-master-Payment-Practices-W1-GB-Simple branch May 18, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants