[WIP] Fix duplicate Codeunit ID collision by changing ID to 4610

[Copilot]

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Original prompt

Fix failing PR build due to duplicate object ID collision: Codeunit 4581 is defined in multiple apps (Sales Order Agent and External File Storage ...). Change the conflicting codeunit ID from 4581 to 4610 in the relevant app in microsoft/BCApps.

Context from failing job (ref a85859f): installation of Sales Order Agent fails with error: "The application object of type 'CodeUnit' with the ID '4581' is defined in multiple apps" and the workflow aborts from build/scripts/ImportTestDataInBcContainer.ps1 line 93.

Task:

1. Locate the AL object defining codeunit 4581 in this repo that is conflicting (likely in an app related to External File Storage, or whichever app in this PR introduces the duplicate).
2. Change its object ID from 4581 to 4610.
3. Update all references to that codeunit ID throughout the repo (e.g., CODEUNIT::... references, permissions, tests, app.json if needed, any .al usages).
4. Ensure compilation/tests still pass.

Notes:

• Use the repo contents at/around the PR branch; use default branch if necessary, but ensure the fix applies to the PR.
• Keep changes minimal and localized.
• If there are multiple codeunits with ID 4581, only change the one that conflicts with Sales Order Agent (not Sales Order Agent itself unless that is the intended change).
• Add/adjust comments only if necessary.

Reference URL: https://github.com/microsoft/BCApps/actions/runs/24447802123/job/71433070660?pr=5833

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: Please find a solution for this failing job. Use the logs, job definition, and any referenced files where the failure occurred. Keep your response focused on the solution and include code suggestions when appropriate.

Assistant: The job fails while importing/installing apps into the BC container because Sales Order Agent cannot be installed due to an object ID collision:

The application object of type 'CodeUnit' with the ID '4581' is defined in multiple apps. The apps are: Sales Order Agent by Microsoft 29.0.48994.0; External File Storage - ...

After 3 retries, the pipeline aborts and the step errors out from:

• build/scripts/ImportTestDataInBcContainer.ps1: line 93 (per the log)
• Final error: Failed to install apps: Sales Order Agent

What to change (solution)

You need to ensure that only one app providing Codeunit 4581 is present/installed during the container app installation phase. In practice that means adjusting the app set (test data import / dependency installation list) so the pipeline does either:

Option A (preferred): Don’t install Sales Order Agent in this job

If Sales Order Agent is not required for the tests/data import being executed in this PR build, exclude it from the “install apps in container” list used by ImportTestDataInBcContainer.ps1.

Code suggestion (in build/scripts/ImportTestDataInBcContainer.ps1, around the failing install block near line ~93):
Add a guard that filters out Sales Order Agent when an app with the conflicting object is present (or always, if it’s never needed here). Conceptually:

# Example: remove Sales Order Agent from the install list for this pipeline
$appsToInstall = $appsToInstall | Where-Object { $_.Name -ne 'Sales Order Agent' }

If the script installs from a dependency/app artifact list, apply the filter there (before calling the install/publish routine).

This will allow the rest of the apps to install and the job to proceed.

Option B: Ensure External File Storage is not published/installed at the same time

If Sales Order Agent is required, then remove/avoid the other app that also defines Codeunit 4581 (the log shows it as “External File Storage - …”). That typically means:

• removing it from the dependency set being published into the container, or
• preventing it from being installed/published in that test run.

The key is: only one of the two apps may be present with that object ID.

Option C (structural fix): Change the object ID in one of the apps

If your PR introduces/changes the “External File Storage …” app (or if you control it), the long-term correct fix is to move the conflicting Codeunit off ID 4581 into a valid range for that app, and update references accordingly.

This is the cleanest from a product perspective, but it’s also the most invasive.

Why this is the right fix

The failure is not a transient install issue; it’s a Business Central rule: duplicate object IDs across installed/published apps are not allowed. Retrying won’t help (as seen in attempts 1–3). The pipeline must avoid publishing/installing both apps that contain Codeunit 4581.

Quick validation

After applying Option A or B, the failing step should no longer hit:

• Attempt X to install Sales Order Agent ... CodeUnit 4581 is defined in multiple apps
  and the script should not end with:
• `Failed to install apps: Sales Order ...

This pull request was created from Copilot chat.