Skip to content

[releases/28.x] [MCP] Loosen API page restriction beyond APIV2 #8260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
onbuyuka wants to merge 1 commit into
base: releases/28.x
Choose a base branch
from
+13 −10
Open

[releases/28.x] [MCP] Loosen API page restriction beyond APIV2 #8260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions ...ystem Application/App/MCP/src/Configuration/Codeunits/MCPConfigImplementation.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ codeunit 8351 "MCP Config Implementation"
ToolsCannotBeAddedToDefaultConfigErr: Label 'Tools cannot be added to the default configuration.';
PageNotFoundErr: Label 'Page not found.';
InvalidPageTypeErr: Label 'Only API pages are supported.';
InvalidAPIVersionErr: Label 'Only API v2.0 pages are supported.';
APIToolNotSupportedErr: Label 'This API page is not available for MCP configuration.';
DefaultMCPConfigurationDescriptionLbl: Label 'Default MCP configuration';
DynamicToolModeRequiredErr: Label 'Dynamic tool mode needs to be enabled to discover read-only objects.';
VersionNotValidErr: Label 'The API version is not valid for the selected tool.';
Expand Down Expand Up @@ -470,8 +470,8 @@ codeunit 8351 "MCP Config Implementation"
MCPAPIConfigToolLookup: Page "MCP API Config Tool Lookup";
begin
PageMetadata.SetRange(PageType, PageMetadata.PageType::API);
PageMetadata.SetFilter(APIPublisher, '<>%1', 'microsoft');
PageMetadata.SetFilter("AL Namespace", '<>%1', 'Microsoft.API.V1');
PageMetadata.SetFilter(APIVersion, '<>%1', 'beta');

MCPAPIConfigToolLookup.LookupMode := true;
MCPAPIConfigToolLookup.SetTableView(PageMetadata);
Expand All @@ -488,7 +488,10 @@ codeunit 8351 "MCP Config Implementation"
begin
PageMetadata.SetLoadFields(PageType, APIPublisher, APIGroup);
PageMetadata.SetRange(PageType, PageMetadata.PageType::API);
PageMetadata.SetFilter(APIPublisher, '<>%1&<>%2', '', 'microsoft');
PageMetadata.SetFilter(APIPublisher, '<>%1', '');
PageMetadata.SetFilter("AL Namespace", '<>%1', 'Microsoft.API.V1');
PageMetadata.SetFilter(APIVersion, '<>%1', 'beta');

if not PageMetadata.FindSet() then
exit;

Expand Down Expand Up @@ -532,11 +535,11 @@ codeunit 8351 "MCP Config Implementation"
if not ValidateAPIPublisher then
exit(PageMetadata);

if PageMetadata.APIPublisher = 'microsoft' then
Error(InvalidAPIVersionErr);

if PageMetadata."AL Namespace" = 'Microsoft.API.V1' then
Error(InvalidAPIVersionErr);
Error(APIToolNotSupportedErr);

if PageMetadata.APIVersion = 'beta' then
Error(APIToolNotSupportedErr);

exit(PageMetadata);
end;
Expand All @@ -558,12 +561,12 @@ codeunit 8351 "MCP Config Implementation"
if (APIGroup = '') or (APIPublisher = '') then
exit;

if APIPublisher = 'microsoft' then
exit;

PageMetadata.SetRange(PageType, PageMetadata.PageType::API);
PageMetadata.SetFilter(APIPublisher, APIPublisher);
PageMetadata.SetFilter(APIGroup, APIGroup);
PageMetadata.SetFilter("AL Namespace", '<>%1', 'Microsoft.API.V1');
PageMetadata.SetFilter(APIVersion, '<>%1', 'beta');

if not PageMetadata.FindSet() then
exit;

Expand Down
Loading