[MCP] Toggle Default via field on MCP Configuration pages#8315
Merged
Conversation
Replace the Set as Default / Clear Default actions on the MCP Config Card and MCP Config List pages with an editable Default field that toggles the designation directly. The new field's OnValidate trigger calls the existing MCPConfigImplementation.SetAsDefaultConfiguration / ClearDefaultConfiguration helpers, matching the previous action behaviour. Fixes AB#612699 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fold the explanation from the removed Clear Default action ('the system reverts to built-in default settings') into the Default field's tooltip, so the information surfaced by the old actions is still discoverable on hover.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The OnValidate trigger already runs with Rec.Default set to the user's new value, and the framework persists it after the trigger returns, so the page does not need an explicit refresh to display the toggled state. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Missing AccessByPermission on Default fieldThe removed SetAsDefault and ClearDefault actions both declared AccessByPermission = tabledata "MCP Configuration" = M, providing an explicit UI-level permission guard. The new Default field's OnValidate trigger has no equivalent AccessByPermission property, so the UI-level guard is silently dropped. Recommendation:
Line mapping was unavailable, so this was posted as an issue comment. 👍 useful · ❤️ especially valuable · 👎 wrong - reply with why |
onbuyuka
pushed a commit
that referenced
this pull request
May 26, 2026
Manual backport of PR #8315 (4 commits: eb1b76e, fab30ab, 1e061fc, 6fdb460). Couldn't cherry-pick because main was restructured into Column1/Column2 page groups while releases/28.x keeps the flat structure. Card page: Replace Set as Default / Clear Default actions with an editable Default field. OnValidate calls SetAsDefaultConfiguration / ClearDefaultConfiguration. Tooltip extended to describe both directions. List page: Remove the same actions and their promoted actionrefs; extend the Default field tooltip. The list page field stays read-only (matches main).
darjoo
approved these changes
May 27, 2026
gggdttt
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the Set as Default / Clear Default actions on the MCP Configuration Card and List pages with an editable Default field. The new field's
OnValidatetrigger toggles the designation directly via the existingMCPConfigImplementation.SetAsDefaultConfiguration/ClearDefaultConfigurationhelpers, so behaviour is unchanged - just exposed through the field instead of two separate actions.Changes
MCP Config Card(page 8351): madeDefaultfield editable when the row is not the built-in default; addedOnValidatetrigger; removedSetAsDefaultandClearDefaultactions and their promoted refs.MCP Config List(page 8350): removedSetAsDefaultandClearDefaultrepeater actions and their promoted refs (the column'sDefaultfield already toggles the designation now).Fixes AB#612699