28.x: Render per-row Currency Code in Aged Accounts Receivable/Payable Excel#8424
Open
mynjj wants to merge 4 commits into
Open
28.x: Render per-row Currency Code in Aged Accounts Receivable/Payable Excel#8424mynjj wants to merge 4 commits into
mynjj wants to merge 4 commits into
Conversation
The CurrencyCode column was bound to a single AgingData-buffer-wide variable (CurrencyCodeDisplayCode) computed once after InsertAgingData, so every row of a customer/vendor displayed the same currency — the last one inserted. When a customer/vendor had entries in multiple currencies, foreign-currency rows showed the LCY code (or vice versa). Bind the column to AgingData."Currency Code" directly, and fall back to G/L Setup's LCY Code at insertion time when the ledger entry's Currency Code is empty. Fixes AB#637444
CurrencyCodeDisplayCode is a protected variable and cannot be removed, so assign AgingData."Currency Code" to it after InsertAgingData. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8423. Fixes AB#637449.