Skip to content

fix: preserve constness for AVX2 y column pointer#426

Open
tsubasakong wants to merge 1 commit intomicrosoft:mainfrom
tsubasakong:fix/407-clang-const-pointer
Open

fix: preserve constness for AVX2 y column pointer#426
tsubasakong wants to merge 1 commit intomicrosoft:mainfrom
tsubasakong:fix/407-clang-const-pointer

Conversation

@tsubasakong
Copy link

Summary

  • make the AVX2 y_col pointer const-correct in src/ggml-bitnet-mad.cpp
  • fix the clang build error reported in Compiler error #407 when y is treated as const int8_t *

Validation

  • clang++ -std=c++17 -target x86_64-apple-darwin -isysroot "$(xcrun --sdk macosx --show-sdk-path)" -Iinclude -I3rdparty/llama.cpp/ggml/include -I3rdparty/llama.cpp/ggml/src -I3rdparty/llama.cpp/include -I3rdparty/llama.cpp/src -mavx2 -c src/ggml-bitnet-mad.cpp -o /tmp/ggml-bitnet-mad.o
  • git diff --check

Fixes #407.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiler error

1 participant