fix: change y_col to const int8_t pointer for better type safety - this is needed for intel mac setup using conda#483
Closed
DenisValeev wants to merge 1 commit intomicrosoft:mainfrom
Closed
Conversation
…is is needed for intel mac setup using conda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi, a summary of what this fixes:
PR Description: Fix const-correctness in
ggml-bitnet-mad.cppfor Clang compatibilitySummary
This PR fixes a build-breaking compilation error on macOS (Apple Clang) by correctly qualifying
y_colas aconstpointer insrc/ggml-bitnet-mad.cpp.The Problem
When building on macOS using Apple Clang (version 17.0.0+), the compiler throws the following error:
This occurs because the variable
yis passed or cast as aconstpointer. Performing pointer arithmetic on it (e.g.,y + col * by) results in aconstpointer. Assigning this result to a non-constint8_t * y_colviolates C++ type safety by implicitly discarding theconstqualifier.While some versions of GCC might only issue a warning, modern Clang—especially on Apple Silicon—treats this as a fatal error by default or under strict build flags.
The Fix
The variable
y_colis only used for read operations in the subsequent logic. By changing the declaration toconst int8_t * y_col, we: