Skip to content

Facebook handover#70

Merged
Kaiqb merged 10 commits intomasterfrom
v-kydela/FacebookHandover
May 31, 2019
Merged

Facebook handover#70
Kaiqb merged 10 commits intomasterfrom
v-kydela/FacebookHandover

Conversation

@v-kydela
Copy link
Copy Markdown

This pull request contains the code for the upcoming Facebook handover blog post

@v-kydela v-kydela requested a review from Kaiqb May 24, 2019 21:52
@Shobhit1
Copy link
Copy Markdown

Shobhit1 commented May 29, 2019

I am not sure why I am added as a reviewer here. Please remove me from this.

Copy link
Copy Markdown
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions. Great example Kyle!

Thanks for taking on this project! I think our Messenger users will find this extremely helpful.

Comment thread blog-samples/CSharp/FacebookHandover/FacebookModel/FacebookThreadControlHelper.cs Outdated
Comment thread blog-samples/CSharp/FacebookHandover/FacebookModel/FacebookPage.cs Outdated
Comment thread blog-samples/CSharp/FacebookHandover/Primary/Bots/PrimaryBot.cs Outdated
Comment thread blog-samples/CSharp/FacebookHandover/Primary/Bots/PrimaryBot.cs Outdated
Comment thread blog-samples/CSharp/FacebookHandover/FacebookModel/FacebookPage.cs Outdated
Comment thread blog-samples/CSharp/FacebookHandover/Secondary/Bots/SecondaryBot.cs Outdated
Comment thread blog-samples/CSharp/FacebookHandover/Secondary/Bots/SecondaryBot.cs Outdated
Comment thread blog-samples/CSharp/FacebookHandover/Primary/Bots/PrimaryBot.cs
@v-kydela v-kydela removed the request for review from Shobhit1 May 30, 2019 16:20
Copy link
Copy Markdown
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (great job on this Kyle!)

{
public static class FacebookThreadControlHelper
{
public const string GraphApiBaseUrl = "https://graph.facebook.com/v2.6/me/{0}?access_token={1}";
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use 3.3?

requestMessage.Content = stringContent;
requestMessage.Content.Headers.ContentType = System.Net.Http.Headers.MediaTypeHeaderValue.Parse("application/json; charset=utf-8");

using (var client = new HttpClient())
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use static HttpClient

Comment thread blog-samples/CSharp/FacebookHandover/FacebookModel/FacebookThreadControlHelper.cs Outdated
Comment thread blog-samples/CSharp/FacebookHandover/FacebookModel/FacebookThreadControlHelper.cs Outdated
@Kaiqb Kaiqb merged commit 9f50056 into master May 31, 2019
@Kaiqb Kaiqb deleted the v-kydela/FacebookHandover branch May 31, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants