This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Provide more memory to Node in Docker#1670
Merged
a-b-r-o-w-n merged 3 commits intomasterfrom Dec 2, 2019
Merged
Conversation
Contributor
|
I did some investigation on this previously, and i try to set --max-old-space-size to Any size bigger than that, like 4096, will result in a OOF, because the container is asking more, but the system refuse to provide. So @benbrown can you test with another machine? see if this will work? |
Contributor
Author
|
@boydc2014 Are you suggesting that I need to test this on a machine with more RAM? |
a-b-r-o-w-n
approved these changes
Dec 2, 2019
Contributor
I was suggesting testing with a machine with less RAM, :) . I think i figured out |
Contributor
Author
|
I don't understand how computers work anymore. |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Add
ENV NODE_OPTIONS "--max-old-space-size=4096"to the Dockerfile to prevent Node from running out of memory inside the containerTask Item
refs #1669
Type of change
Checklist