Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

build: add ability to configure runtime path#1713

Merged
boydc2014 merged 10 commits intomasterfrom
docker-windows
Dec 9, 2019
Merged

build: add ability to configure runtime path#1713
boydc2014 merged 10 commits intomasterfrom
docker-windows

Conversation

@a-b-r-o-w-n
Copy link
Copy Markdown
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Dec 6, 2019 •
edited
Loading

refs #1669

  • Fixes issue when creating bots in docker.
  • Adds a very simple e2e health check that starts docker compose and hits localhost:3000

I attempted to run the build on all platforms but mac and windows had errors (unrelated to the docker-compose bit itself).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 6, 2019

Coverage Status

Coverage increased (+0.02%) to 40.967% when pulling 54e326b on docker-windows into 797900e on master.

@a-b-r-o-w-n a-b-r-o-w-n marked this pull request as ready for review December 6, 2019 19:58
@boydc2014
Copy link
Copy Markdown
Contributor

boydc2014 commented Dec 9, 2019

Looks good, verified on my side and on @liweitian.

@boydc2014 boydc2014 merged commit 7677101 into master Dec 9, 2019
@boydc2014 boydc2014 deleted the docker-windows branch December 9, 2019 09:09
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

1 more reviewer

@boydc2014 boydc2014 boydc2014 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a-b-r-o-w-n @boydc2014