This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: one lg template error mess up others#1733
Merged
a-b-r-o-w-n merged 2 commits intomicrosoft:masterfrom Dec 9, 2019
Merged
Conversation
zhixzhan
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
boydc2014
approved these changes
Dec 9, 2019
boydc2014
reviewed
Dec 9, 2019
| } catch (err) { | ||
| diagnostics.push(new Diagnostic(err.message, id, DiagnosticSeverity.Error)); | ||
| } | ||
| try { |
Contributor
There was a problem hiding this comment.
We are fully aware that, there are some confusing and inconvenience how LG library provide features like validation and parsing, the core issue is parsing is not as tolerant as checker and CRUD functions.
Here is a thread in LG side, that we will consolidate the interface in LG side, and unify the experience, especially on error handling, https://github.com/microsoft/botbuilder-dotnet/issues/3084.
Hopefully with this work, the code in Composer will be simplified significantly. Please take a look, and leave your opinions.
a-b-r-o-w-n
approved these changes
Dec 9, 2019
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Greed try parse lgFile, fix one lg template error cause others blank field
If this is a bug fix, please describe the root cause and analysis of this problem.
Task Item
Fix #1732
Type of change
Please delete options that are not relevant.
Checklist
Screenshots
Please include screenshots or gifs if your PR include UX changes.
