This repository was archived by the owner on Jul 9, 2025. It is now read-only.
a11y: adjust id numbers in dialog samples#2239
Merged
Conversation
Some of the dialog files in the Sample files had duplicate ID fields. This change should eliminate these duplicates, letting the "duplicate-id" a11y test past.
beyackle
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
a-b-r-o-w-n
approved these changes
Mar 11, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the dialog files in the Sample files had duplicate ID fields. This change should eliminate these duplicates, letting the "duplicate-id" a11y test past.
Description
The side dialog is created from the sample .dialog files, so the fix here was to check that the ids in each file contain no duplicate ID fields and change the ones that did.
Task Item
Closes #2142