fix: remove explicit `UseCosmosDbPersistentStorage` `UseTranscriptLoggerMiddleware` settings and use API to get tenant ID by zidaneymar · Pull Request #2964 · microsoft/BotFramework-Composer

zidaneymar · 2020-05-09T02:49:23Z

Description

Remove explicit UseCosmosDbPersistentStorage UseTranscriptLoggerMiddleware settings
Add more error details to provision script
Add guid identifier to resources (referring to OA Solution)
Add tenant id retrieving in provision script.

Task Item

fixes #2927
fixes #2858

Screenshots

Have more details about the failed provision

github-actions · 2020-05-09T02:58:15Z

Coverage remained the same at 0.0% when pulling 4d509f9 on qika/fixcosmos into 4c69132 on master.

carlosscastro

This is great! One small comment: Since you deprecated a few of the settings, it would be great to remove them from everywhere. They are still referenced in the appsettings.json file in both azure functions and azure web app runtimes. Example here. I'll set myself as waiting just to track this pending item. If there is a reason to keep them that I don't know of, all good -- just let me know :)

…ework-Composer into qika/fixcosmos

carlosscastro · 2020-05-09T21:51:21Z

Thanks for the update, it's looking great. Most of my comments are minor, the only one that I feel is very relevant is that we need to somehow allow users to reach the error information when retrieving the tenant, otherwise this will be extremely hard to troubleshoot when things go wrong.

If there is some technical complexity around extracting this info in a nice way, we could at least try to log it somehwere or show it when people pass verbose or something. Let me know if you run into issues here and we can work it out.

…ework-Composer into qika/fixcosmos

luhan2017 · 2020-05-11T09:29:45Z

Thanks Qi, with this change: "Add guid identifier to resources (referring to OA Solution)" I can query the provision instance number for composer runtime in azure data explorer now:

benbrown

minor changes.

…ework-Composer into qika/fixcosmos

zidaneymar · 2020-05-13T02:10:40Z

@benbrown Hi Ben, the issue about the json array empty error handling has been fixed. Could you please help review again, thanks!

Co-authored-by: Carlos Castro <carlosscastro@users.noreply.github.com>

…gerMiddleware` settings and use API to get tenant ID (microsoft#2964) * remove cosmosdb feature config and transcript logger feature config * add more error details in deployment script. * add tenant id retrieving, add reource guid identifier * update appsettings * add config section validation * add more error message and comments * fix: update bf-lu version to 4.9.0-RC6 * add error handling for tenant api * add error handling * update error msg Co-authored-by: Carlos Castro <carlosscastro@users.noreply.github.com> * update err msg Co-authored-by: Carlos Castro <carlosscastro@users.noreply.github.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: leilzh <leilzh@microsoft.com> Co-authored-by: Carlos Castro <carlosscastro@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

Qi Kang added 2 commits May 8, 2020 16:34

remove cosmosdb feature config and transcript logger feature config

b8ae818

add more error details in deployment script.

4d509f9

zidaneymar requested review from a-b-r-o-w-n, benbrown, beyackle, boydc2014, carlosscastro, corinagum, cwhitten, luhan2017, srinaath and tonyanziano as code owners May 9, 2020 02:49

Merge branch 'master' into qika/fixcosmos

12b16ce

carlosscastro reviewed May 9, 2020

View reviewed changes

Comment thread runtime/dotnet/azurefunctions/Startup.cs Outdated

carlosscastro suggested changes May 9, 2020

View reviewed changes

Qi Kang added 4 commits May 9, 2020 20:58

add tenant id retrieving, add reource guid identifier

eeeb406

Merge branch 'qika/fixcosmos' of https://github.com/microsoft/BotFram…

9c87ce7

…ework-Composer into qika/fixcosmos

update appsettings

acc5b30

add config section validation

d2373c3

carlosscastro suggested changes May 9, 2020

View reviewed changes

carlosscastro reviewed May 9, 2020

View reviewed changes

Comment thread runtime/dotnet/azurefunctions/appsettings.json

luhan2017 and others added 3 commits May 11, 2020 11:21

Merge branch 'master' into qika/fixcosmos

a31462b

add more error message and comments

0a602ec

Merge branch 'qika/fixcosmos' of https://github.com/microsoft/BotFram…

d014e5e

…ework-Composer into qika/fixcosmos

luhan2017 added R9-RC and removed R9-RC labels May 11, 2020

luhan2017 changed the title ~~fix: remove explicit UseCosmosDbPersistentStorage UseTranscriptLoggerMiddleware settings~~ fix: remove explicit UseCosmosDbPersistentStorage UseTranscriptLoggerMiddleware settings and use API to get tenant ID May 11, 2020

fix: update bf-lu version to 4.9.0-RC6

fae37fc

benbrown reviewed May 11, 2020

View reviewed changes

Comment thread Composer/packages/lib/bot-deploy/src/botProjectDeploy.ts

benbrown approved these changes May 11, 2020

View reviewed changes

benbrown suggested changes May 11, 2020

View reviewed changes

carlosscastro reviewed May 11, 2020

View reviewed changes

Comment thread Composer/packages/lib/bot-deploy/src/botProjectDeploy.ts

luhan2017 and others added 3 commits May 12, 2020 13:13

Merge branch 'master' into qika/fixcosmos

e58dc42

add error handling for tenant api

77668bd

Merge branch 'qika/fixcosmos' of https://github.com/microsoft/BotFram…

6dbd6b0

…ework-Composer into qika/fixcosmos

benbrown reviewed May 12, 2020

View reviewed changes

Comment thread Composer/packages/lib/bot-deploy/src/botProjectDeploy.ts Outdated

add error handling

645b0c4

Merge branch 'master' into qika/fixcosmos

00ffa23

carlosscastro previously approved these changes May 13, 2020

View reviewed changes

Comment thread Composer/packages/lib/bot-deploy/src/botProjectDeploy.ts Outdated

Comment thread Composer/plugins/samples/assets/shared/scripts/provisionComposer.js Outdated

update error msg

12a5732

Co-authored-by: Carlos Castro <carlosscastro@users.noreply.github.com>

zidaneymar dismissed carlosscastro’s stale review via 12a5732 May 13, 2020 06:58

update err msg

eb574c4

Co-authored-by: Carlos Castro <carlosscastro@users.noreply.github.com>

carlosscastro approved these changes May 13, 2020

View reviewed changes

benbrown approved these changes May 13, 2020

View reviewed changes

Merge branch 'master' into qika/fixcosmos

0855234

cwhitten approved these changes May 13, 2020

View reviewed changes

cwhitten merged commit 652868a into master May 13, 2020

cwhitten deleted the qika/fixcosmos branch May 13, 2020 23:50

This was referenced May 13, 2020

Bot with Luis throws 500 error once deployed on Azure #2858

Closed

Do we need explicit UseCosmosDbPersistentStorage setting #2927

Closed

cxbuilders mentioned this pull request May 15, 2020

provisionComposer script fails #3075

Closed

a-b-r-o-w-n mentioned this pull request May 15, 2020

release: prepare release notes #3096

Merged

Uh oh!

Conversation

zidaneymar commented May 9, 2020 • edited by luhan2017 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Task Item

Screenshots

Uh oh!

github-actions Bot commented May 9, 2020

Uh oh!

Uh oh!

carlosscastro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carlosscastro commented May 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luhan2017 commented May 11, 2020

Uh oh!

Uh oh!

benbrown left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

zidaneymar commented May 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zidaneymar commented May 9, 2020 •

edited by luhan2017

Loading

carlosscastro commented May 9, 2020 •

edited

Loading

benbrown left a comment •

edited

Loading

zidaneymar commented May 13, 2020 •

edited

Loading