Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@tdurnford
Copy link
Collaborator

Description

  • Refactored the select skill ui-plugin to simplify logic
    • Previously, the <BeginSkillDialogField />component was responsible for updating the dialog data and the skills setting.
    • This moves the responsibility for updating the dialog to the <SelectSkillDialogField /> component and the responsibility to manage the settings to the <SelectEndpointField />component.
  • Removes logic to support backward compatibility since it will be addressed in another in PR in R11 by @srinaath

Task Item

Closes #4143

@coveralls
Copy link

coveralls commented Sep 18, 2020

Coverage Status

Coverage decreased (-0.2%) to 55.514% when pulling b598777 on tdurnford:fix/begin-skill into ecfd12e on microsoft:main.

@tdurnford tdurnford merged commit def9f80 into microsoft:main Sep 22, 2020
@tdurnford tdurnford deleted the fix/begin-skill branch September 22, 2020 18:31
alanlong9278 added a commit to alanlong9278/BotFramework-Composer that referenced this pull request Sep 28, 2020
* main:
  fix: update l10n file (microsoft#4247)
  fix: fix loading of extensions by removing sample-ui-plugin (microsoft#4251)
  fix: split qna resource to another template (microsoft#4212)
  feat: UI Schema - Recognizer (microsoft#4135)
  fix: Change http to https for petstore.swagger.io calls (microsoft#4238)
  feat: install remote extensions from npm (microsoft#4224)
  fix: refactored select skill ui-plugin (microsoft#4207)
  feat: Added fieldSets to UIOptions (microsoft#4231)
  fix: New LG template not sync to other locale files (microsoft#4230)
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
* main:
  fix: update l10n file (microsoft#4247)
  fix: fix loading of extensions by removing sample-ui-plugin (microsoft#4251)
  fix: split qna resource to another template (microsoft#4212)
  feat: UI Schema - Recognizer (microsoft#4135)
  fix: Change http to https for petstore.swagger.io calls (microsoft#4238)
  feat: install remote extensions from npm (microsoft#4224)
  fix: refactored select skill ui-plugin (microsoft#4207)
  feat: Added fieldSets to UIOptions (microsoft#4231)
  fix: New LG template not sync to other locale files (microsoft#4230)
benbrown pushed a commit that referenced this pull request Jun 11, 2021
* main:
  fix: update l10n file (#4247)
  fix: fix loading of extensions by removing sample-ui-plugin (#4251)
  fix: split qna resource to another template (#4212)
  feat: UI Schema - Recognizer (#4135)
  fix: Change http to https for petstore.swagger.io calls (#4238)
  feat: install remote extensions from npm (#4224)
  fix: refactored select skill ui-plugin (#4207)
  feat: Added fieldSets to UIOptions (#4231)
  fix: New LG template not sync to other locale files (#4230)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* fix: refactored select skill ui-plugin

* small fixed

* removed redundant fields from order
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing the skill endpoint in the Begin Skill property editor does not properly update the skill settings

4 participants